[jira] [Commented] (SENTRY-380) Clean up some grantorPrincipal semantics

["Sravya Tirukkovalur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120925#comment-14120925 ] 

Sravya Tirukkovalur commented on SENTRY-380:
--------------------------------------------

Also there are some paths where grantor_principal is not being set correctly causing some test failues on some dbs:
{noformat}
ERROR: null value in column "GRANTOR_PRINCIPAL" violates not-null constraint
{noformat}


> Clean up some grantorPrincipal semantics
> ----------------------------------------
>
>                 Key: SENTRY-380
>                 URL: https://issues.apache.org/jira/browse/SENTRY-380
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>             Fix For: 1.5.0
>
>
> Came from SENTRY-327 review:
> - I do not think grantorPrincipal is required for createRole, we should instead pass it for alterSentryRoleGrantPrivilege and alterSentryRoleRevokePrivilege?
> - As we pass grantorPrincipal as the user invoking the thrift request(requestorUserName), we may keep it consistent and avoid possibility of passing different requestorUserName and grantorPrincipal by getting rid of grantorPrincipal field in the TSentryPrivilege and TSentryRole?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)