You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jubebo (via GitHub)" <gi...@apache.org> on 2023/06/21 09:48:38 UTC
[GitHub] [beam] jubebo opened a new pull request, #27199: recursive call to generate user type from bq schema - addresses #27166
jubebo opened a new pull request, #27199:
URL: https://github.com/apache/beam/pull/27199
**This is what I've done**
- suggested to rename `dict_of_tuples` to `field_names_and_types`
- added recursive call to `generate_user_type_from_bq_schema` as suggested above
_This change implies that the object `field_names_and_types` passed to `named_fields_to_schema` may already contain a named tuple object instead of plain python types. Therefore:_
- adjusted input to `named_fields_to_schema` to prevent it from parsing all sequence elements which contain already processed elements
- added new parameter to `named_tuple_from_schema` to overwrite certain positions in returned named tuple with already processed elements
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jubebo closed pull request #27199: recursive call to generate user type from bq schema - addresses #27166
Posted by "jubebo (via GitHub)" <gi...@apache.org>.
jubebo closed pull request #27199: recursive call to generate user type from bq schema - addresses #27166
URL: https://github.com/apache/beam/pull/27199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jubebo commented on pull request #27199: recursive call to generate user type from bq schema - addresses #27166
Posted by "jubebo (via GitHub)" <gi...@apache.org>.
jubebo commented on PR #27199:
URL: https://github.com/apache/beam/pull/27199#issuecomment-1603967449
Hi Ritesh, thanks for the hint. I will check for python lints before my next commits. @svetakvsundhar has suggested to break down the changes into several PRs, so I have opened [this](https://github.com/apache/beam/pull/27217). Will therefore close this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27199: recursive call to generate user type from bq schema - addresses #27166
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27199:
URL: https://github.com/apache/beam/pull/27199#issuecomment-1600555863
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27199?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27199](https://app.codecov.io/gh/apache/beam/pull/27199?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (695ddcb) into [master](https://app.codecov.io/gh/apache/beam/commit/69cd6ef06b377050a1289df011c5b76bb8b5c2d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (69cd6ef) will **decrease** coverage by `0.01%`.
> The diff coverage is `86.95%`.
```diff
@@ Coverage Diff @@
## master #27199 +/- ##
==========================================
- Coverage 71.62% 71.62% -0.01%
==========================================
Files 855 855
Lines 104225 104236 +11
==========================================
- Hits 74656 74654 -2
- Misses 28021 28034 +13
Partials 1548 1548
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.08% <86.95%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...python/apache\_beam/io/gcp/bigquery\_schema\_tools.py](https://app.codecov.io/gh/apache/beam/pull/27199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3NjaGVtYV90b29scy5weQ==) | `77.96% <80.00%> (-1.28%)` | :arrow_down: |
| [sdks/python/apache\_beam/typehints/schemas.py](https://app.codecov.io/gh/apache/beam/pull/27199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NjaGVtYXMucHk=) | `89.25% <92.30%> (-0.10%)` | :arrow_down: |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27199/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #27199: recursive call to generate user type from bq schema - addresses #27166
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #27199:
URL: https://github.com/apache/beam/pull/27199#issuecomment-1602676317
Thanks @jubebo ! Welcome to Beam!
You can use this pre-commit hook for catching and fixing python lints - https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27199: recursive call to generate user type from bq schema - addresses #27166
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27199:
URL: https://github.com/apache/beam/pull/27199#issuecomment-1600596364
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label python.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org