You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/06/26 23:19:30 UTC
Review Request 23091: unbundle picojson
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23091/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1173
https://issues.apache.org/jira/browse/MESOS-1173
Repository: mesos-git
Description
-------
Enable mesos to build against the system installed version of picojson.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 429c956
3rdparty/libprocess/configure.ac 27c6ede
src/Makefile.am 9027927
Diff: https://reviews.apache.org/r/23091/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23091: unbundle picojson
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On July 13, 2014, 8 a.m., Adam B wrote:
> > Looks great. Almost identical to the boost version, so it must be right. :)
> > Did you test configure && make check with/without bundled picojson, with --enable_bundled=yes/no, and with/without system picojson installed? (or some relevant combination thereof?)
Checked the following:
default build (bundled)
--without-bundled / --disable-bundled logic for both presence & absence of dependency.
I kept the semantics for the prefixed installed versions --with-picojson=foo but I did not fully test a prefixed installation, I'm relying on the semantics from the other dependencies.
> On July 13, 2014, 8 a.m., Adam B wrote:
> > 3rdparty/libprocess/configure.ac, lines 81-85
> > <https://reviews.apache.org/r/23091/diff/1/?file=618982#file618982line81>
> >
> > tabbing?
Yeah this is weird, the file is a mix.
Opinions?
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23091/#review47692
-----------------------------------------------------------
On July 11, 2014, 4:17 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23091/
> -----------------------------------------------------------
>
> (Updated July 11, 2014, 4:17 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-1173
> https://issues.apache.org/jira/browse/MESOS-1173
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against the system installed version of picojson.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> src/Makefile.am 9027927
>
> Diff: https://reviews.apache.org/r/23091/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23091: unbundle picojson
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23091/#review47692
-----------------------------------------------------------
Ship it!
Looks great. Almost identical to the boost version, so it must be right. :)
Did you test configure && make check with/without bundled picojson, with --enable_bundled=yes/no, and with/without system picojson installed? (or some relevant combination thereof?)
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/23091/#comment83843>
tabbing?
- Adam B
On July 11, 2014, 9:17 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23091/
> -----------------------------------------------------------
>
> (Updated July 11, 2014, 9:17 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-1173
> https://issues.apache.org/jira/browse/MESOS-1173
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against the system installed version of picojson.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> src/Makefile.am 9027927
>
> Diff: https://reviews.apache.org/r/23091/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 23091: unbundle picojson
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23091/
-----------------------------------------------------------
(Updated July 11, 2014, 4:17 p.m.)
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1173
https://issues.apache.org/jira/browse/MESOS-1173
Repository: mesos-git
Description
-------
Enable mesos to build against the system installed version of picojson.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 429c956
3rdparty/libprocess/configure.ac 27c6ede
src/Makefile.am 9027927
Diff: https://reviews.apache.org/r/23091/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 23091: unbundle picojson
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23091/#review46931
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23091]
All tests passed.
- Mesos ReviewBot
On June 26, 2014, 9:19 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23091/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 9:19 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1173
> https://issues.apache.org/jira/browse/MESOS-1173
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable mesos to build against the system installed version of picojson.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 429c956
> 3rdparty/libprocess/configure.ac 27c6ede
> src/Makefile.am 9027927
>
> Diff: https://reviews.apache.org/r/23091/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>