You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Scott Gray (JIRA)" <ji...@apache.org> on 2007/04/08 00:12:32 UTC
[jira] Created: (OFBIZ-876) A few problems when editing orders
A few problems when editing orders
----------------------------------
Key: OFBIZ-876
URL: https://issues.apache.org/jira/browse/OFBIZ-876
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Reporter: Scott Gray
I think there's a still a few issues to be fixed with editing orders:
1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "David Shere (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487780 ]
David Shere commented on OFBIZ-876:
-----------------------------------
Is this where I should report all problems with editing orders?
(The following is all for orders with promotional items, for GZ-1004, quantity 10)
1. If I wish to modify the quantity for a line item, (In this case the GZ-1004), I change the quantity box next to "Ship Group: [00001] 70004 Testerlane Road" and click "Update Items" at the bottom of the order. The error message I get is "Service target threw an unexpected exception (org.ofbiz.order.shoppingcart.ShoppingCart.addPayment(Ljava/lang/String;)V)"
2. I'm not sure if this is covered above, but "Cancel all items" recreates each promotional item as a new line item. They have a "Status: Created" but no times and no additional statuses.
I guess I thought there were more issues but I can't seem to find them now.
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "David Shere (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488077 ]
David Shere commented on OFBIZ-876:
-----------------------------------
Okay My "Create New Order" button now works and my #1 above is also solved. I also switched from Java1.5.07 to Java1.6.0. I'm not sure if one or both solved the problem.
Sorry to muddy up the issue...
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "David Shere (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487793 ]
David Shere commented on OFBIZ-876:
-----------------------------------
"Create as New Order" button also does not work... error message is "Service target threw an unexpected exception (org.ofbiz.order.shoppingcart.ShoppingCart.addPayment(Ljava/lang/String;)V)"
This is on an order with or without promotional items.
If it's the same error message (as my #1 above), it might be the same issue.
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487935 ]
Scott Gray commented on OFBIZ-876:
----------------------------------
Hi David
What are the payment methods being used, it looks like some problem loading the payments into the temp cart.
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487417 ]
Scott Gray commented on OFBIZ-876:
----------------------------------
Number 1 should be resolved with rev. 526496
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487965 ]
Scott Gray commented on OFBIZ-876:
----------------------------------
Scratch that last question, this part of the log looks interesting:
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
java.lang.Thread.run(Thread.java:595)
java.lang.NoSuchMethodError: org.ofbiz.order.shoppingcart.ShoppingCart.addPayment(Ljava/lang/String;)V <--
org.ofbiz.order.shoppingcart.ShoppingCartServices.loadCartFromOrder(ShoppingCartServices.java:246)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
Anyone know any reasons why a NoSuchMethodError would be occuring here?
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487872 ]
Scott Gray commented on OFBIZ-876:
----------------------------------
Hi David
I haven't come across the exception addPayment exception, could you possibly attach a log file with the error?
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520097 ]
Bilgin Ibryam commented on OFBIZ-876:
-------------------------------------
Hi Scott,
this issue: https://issues.apache.org/jira/browse/OFBIZ-1198 is also related to canceling orders. I also applied a patch for it. May be you can take a look when possible.
Best regards,
Bilgin Ibryam
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487985 ]
Scott Gray commented on OFBIZ-876:
----------------------------------
David,
The method signatures changed recently on ShoppingCart.addPayment, have you done an "ant clean" and rebuild since your last update?
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-876) A few problems when editing orders
Posted by "David Shere (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Shere updated OFBIZ-876:
------------------------------
Attachment: ofbiz.log.tar.gz
The exception is at around 11:11AM today.
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489013 ]
Scott Gray commented on OFBIZ-876:
----------------------------------
In rev. 529138 I've committed a few more fixes which should resolve problems with the "cancel all" action. It probably still needs more testing, so if anyone comes across any problems, please let me know.
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555999#action_12555999 ]
Jacques Le Roux commented on OFBIZ-876:
---------------------------------------
Should we close this issue ? OFBIZ-1198 is already closed BTW...
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-876) A few problems when editing orders
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487988 ]
Jacopo Cappellato commented on OFBIZ-876:
-----------------------------------------
David,
did you try to rebuild your system?
ant clean
ant build
Jacopo
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-876) A few problems when editing orders
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-876.
---------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Scott Gray
> A few problems when editing orders
> ----------------------------------
>
> Key: OFBIZ-876
> URL: https://issues.apache.org/jira/browse/OFBIZ-876
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Reporter: Scott Gray
> Assignee: Scott Gray
> Fix For: SVN trunk
>
> Attachments: ofbiz.log.tar.gz
>
>
> I think there's a still a few issues to be fixed with editing orders:
> 1. Multiple order change emails are being sent out (I think one is sent for every orderItem status change)
> 2. I don't think all inventory reservations should be cancelled at the start, this puts the order to the back of the queue even if a orderItem didn't change during the edit.
> 3. Promo lines shouldn't appear to be editable in editorderitems.ftl as they can't actually be edited
> 4. Promos that apply before and after an edit shouldn't be cancelled and then recreated, it makes a mess of the order and puts the reservation to the back of the queue.
> I'll keep them as one issue for now as they are pretty closely related, but if things drag on perhaps we should look at splitting them up
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.