You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/04/10 20:16:55 UTC

[GitHub] [knox] risdenk opened a new pull request #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0

risdenk opened a new pull request #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0
URL: https://github.com/apache/knox/pull/308
 
 
   ## What changes were proposed in this pull request?
   
   * Upgrade pac4j to 4.0.0
   * Upgrade opensaml to 4.0.0
   
   ## How was this patch tested?
   
   * `mvn -U -T.75C clean verify -Ppackage,release -Dshellcheck`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] leleuj edited a comment on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0

Posted by GitBox <gi...@apache.org>.
leleuj edited a comment on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0
URL: https://github.com/apache/knox/pull/308#issuecomment-613498476
 
 
   Be careful: `pac4j-opensaml` v4.0.0 is based on OpenSAML v4 which requires the JDK 11. Use `pac4j-saml-opensamlv3` v4.0.0 to stay on OpenSAML v3 and JDK 8.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0
URL: https://github.com/apache/knox/pull/308#issuecomment-613499956
 
 
   Thanks @leleuj! I'll update accordingly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0
URL: https://github.com/apache/knox/pull/308#issuecomment-613497114
 
 
   Rebased to get new github actions check as well (expected to fail with same error)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0
URL: https://github.com/apache/knox/pull/308#issuecomment-612263735
 
 
   Need to fix a few more dependencies for this to work:
   
   ```
   Dependency convergence error for org.glassfish.jaxb:jaxb-runtime:2.3.2 paths to dependency are:
   +-org.apache.knox:gateway-provider-security-pac4j:1.4.0-SNAPSHOT
     +-org.apache.knox:gateway-server:1.4.0-SNAPSHOT
       +-com.sun.xml.ws:jaxws-ri:2.3.2
         +-com.sun.xml.ws:jaxws-rt:2.3.2
           +-org.glassfish.jaxb:jaxb-runtime:2.3.2
   and
   +-org.apache.knox:gateway-provider-security-pac4j:1.4.0-SNAPSHOT
     +-org.pac4j:pac4j-saml:4.0.0
       +-org.opensaml:opensaml-storage-impl:4.0.0
         +-org.hibernate:hibernate-core:5.4.12.Final
           +-org.glassfish.jaxb:jaxb-runtime:2.3.1
   
   [WARNING] 
   Dependency convergence error for com.sun.mail:javax.mail:1.6.1 paths to dependency are:
   +-org.apache.knox:gateway-provider-security-pac4j:1.4.0-SNAPSHOT
     +-org.pac4j:pac4j-oidc:4.0.0
       +-com.nimbusds:oauth2-oidc-sdk:7.3
         +-com.sun.mail:javax.mail:1.6.1
   and
   +-org.apache.knox:gateway-provider-security-pac4j:1.4.0-SNAPSHOT
     +-org.pac4j:pac4j-oidc:4.0.0
       +-com.sun.mail:javax.mail:1.6.2
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] leleuj commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0

Posted by GitBox <gi...@apache.org>.
leleuj commented on issue #308: KNOX-2337 - Upgrade pac4j to 4.0.0 and opensaml to 4.0.0
URL: https://github.com/apache/knox/pull/308#issuecomment-613498476
 
 
   Be careful: `pac4j-opensaml` v4.0.0 is based on OpenSAML v4 which requires the JDK 11. Use `pac4j-saml-opensamlv3` to stay on OpenSAML v3 and JDK 8.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services