You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/08 20:51:04 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
dongjoon-hyun opened a new pull request, #42402:
URL: https://github.com/apache/spark/pull/42402
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42402:
URL: https://github.com/apache/spark/pull/42402#issuecomment-1670398162
Could you review this documentation PR when you have some time, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42402:
URL: https://github.com/apache/spark/pull/42402#issuecomment-1670425997
Thank you, @attilapiros . Yes, those configurations mean `fallback`, but this configuration only reuses the static default value which means two configurations are irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a diff in pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "attilapiros (via GitHub)" <gi...@apache.org>.
attilapiros commented on code in PR #42402:
URL: https://github.com/apache/spark/pull/42402#discussion_r1287753664
##########
docs/configuration.md:
##########
@@ -2397,6 +2397,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.3.0</td>
</tr>
+<tr>
+ <td><code>spark.network.timeoutInterval</code></td>
+ <td>60s</td>
Review Comment:
Check `spark.rpc.io.connectionCreationTimeout`, `spark.rpc.io.connectionTimeout`... and `spark.rpc.askTimeout`. All of them referencing to another config where the default comes from.
For `spark.network.timeoutInterval` the default is:
https://github.com/apache/spark/blob/418bba5ad6053449a141f3c9c31ed3ad998995b8/core/src/main/scala/org/apache/spark/internal/config/Network.scala#L48-L52
So IMHO we should mention here `spark.storage.blockManagerTimeoutIntervalMs` as the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42402:
URL: https://github.com/apache/spark/pull/42402#issuecomment-1670427028
Merged to master/3.5/3.4/3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a diff in pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "attilapiros (via GitHub)" <gi...@apache.org>.
attilapiros commented on code in PR #42402:
URL: https://github.com/apache/spark/pull/42402#discussion_r1287753664
##########
docs/configuration.md:
##########
@@ -2397,6 +2397,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.3.0</td>
</tr>
+<tr>
+ <td><code>spark.network.timeoutInterval</code></td>
+ <td>60s</td>
Review Comment:
Check `spark.rpc.io.connectionCreationTimeout`, `spark.rpc.io.connectionTimeout`... and `park.rpc.askTimeout`. All of them referencing to another config where the default comes from.
For `spark.network.timeoutInterval` the default is:
https://github.com/apache/spark/blob/418bba5ad6053449a141f3c9c31ed3ad998995b8/core/src/main/scala/org/apache/spark/internal/config/Network.scala#L48-L52
So IMHO we should mention here `spark.storage.blockManagerTimeoutIntervalMs` as the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42402:
URL: https://github.com/apache/spark/pull/42402#issuecomment-1670642282
No problem at all. Thank you, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
URL: https://github.com/apache/spark/pull/42402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a diff in pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "attilapiros (via GitHub)" <gi...@apache.org>.
attilapiros commented on code in PR #42402:
URL: https://github.com/apache/spark/pull/42402#discussion_r1287769473
##########
docs/configuration.md:
##########
@@ -2397,6 +2397,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.3.0</td>
</tr>
+<tr>
+ <td><code>spark.network.timeoutInterval</code></td>
+ <td>60s</td>
Review Comment:
Oh I see those are not hardcoded values read from the default of the other config. In this case it is fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on a diff in pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "attilapiros (via GitHub)" <gi...@apache.org>.
attilapiros commented on code in PR #42402:
URL: https://github.com/apache/spark/pull/42402#discussion_r1287769473
##########
docs/configuration.md:
##########
@@ -2397,6 +2397,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.3.0</td>
</tr>
+<tr>
+ <td><code>spark.network.timeoutInterval</code></td>
+ <td>60s</td>
Review Comment:
Oh I see those are not hardcoded values. In this case it is fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42402:
URL: https://github.com/apache/spark/pull/42402#issuecomment-1670601230
Late LGTM.
Sorry, I fell asleep yesterday...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org