You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/04/11 07:23:47 UTC

Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58335/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.


Bugs: AMBARI-20718
    https://issues.apache.org/jira/browse/AMBARI-20718


Repository: ambari


Description
-------

We have added a validation check which will check the duplication of action name.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js cccf6d0 


Diff: https://reviews.apache.org/r/58335/diff/1/


Testing
-------

Manual testing done


Thanks,

venkat sairam


Re: Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes

Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58335/#review171547
-----------------------------------------------------------


Ship it!




Ship It!

- Padma Priya N


On April 11, 2017, 7:23 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58335/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 7:23 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20718
>     https://issues.apache.org/jira/browse/AMBARI-20718
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We have added a validation check which will check the duplication of action name.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js cccf6d0 
> 
> 
> Diff: https://reviews.apache.org/r/58335/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58335/#review171534
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On April 11, 2017, 7:23 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58335/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 7:23 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20718
>     https://issues.apache.org/jira/browse/AMBARI-20718
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We have added a validation check which will check the duplication of action name.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js cccf6d0 
> 
> 
> Diff: https://reviews.apache.org/r/58335/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>