You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org> on 2010/04/22 09:17:49 UTC

[jira] Created: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
----------------------------------------------------------------------------------------------------

                 Key: QPID-2531
                 URL: https://issues.apache.org/jira/browse/QPID-2531
             Project: Qpid
          Issue Type: Improvement
            Reporter: Sorin Suciu


The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
So the task of adding a new OSGI module would involve: 
- creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
- adding the new directory to the subant task so it will be build
- updating the build.deps file


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Emmanuel Bourg (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860381#action_12860381 ] 

Emmanuel Bourg commented on QPID-2531:
--------------------------------------

The directory java/broker-plugins/src is empty after this change, I could be removed.

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-2531:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Closed: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sorin Suciu closed QPID-2531.
-----------------------------


> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Emmanuel Bourg (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860536#action_12860536 ] 

Emmanuel Bourg commented on QPID-2531:
--------------------------------------

What part of the build expects this directory? I removed it and I was still able to run 'ant build release' without error.

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860294#action_12860294 ] 

Martin Ritchie commented on QPID-2531:
--------------------------------------

We should update the plugin integration to build a release artefact with installations instructions.

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie resolved QPID-2531.
----------------------------------

    Resolution: Fixed

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860447#action_12860447 ] 

Robbie Gemmell commented on QPID-2531:
--------------------------------------

The java/broker-plugins/src/main/java directory is still required until the build system is updated to fully accomodate the recent changes made to the broker-plugins module. Once that is done it the src/ dir can be removed.

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860543#action_12860543 ] 

Robbie Gemmell commented on QPID-2531:
--------------------------------------

Reopened QPID-2530 to work in the feedback discussed here on Monday.

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860539#action_12860539 ] 

Robbie Gemmell commented on QPID-2531:
--------------------------------------

Using the 'test' target on the broker-plugins module fails if the src directory isnt there because it tries a compile sweep on the moudle wheras the 'build' target is overidden and so does not. I restored the directory temporarily before heading to bed last night so that people dont find on Monday that their automated build/test systems spent the entire weekend failing, it will be removed again on Monday :) 

I actually think the changes made to the broker-plugins module in this JIRA and QPID-2530 need adjusted such that broker-plugins directory is not considered a module any longer and merely a container directory, eg like the management directory containing the various sub modules. That will resolve this issue and allow removal of the src dir.

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sorin Suciu updated QPID-2531:
------------------------------

    Attachment: qpid-2531.patch

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>         Attachments: qpid-2531.patch
>
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2531) Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-2531:
------------------------------------

    Assignee: Martin Ritchie

> Improve the qpid broker build system to automatically build OSGI modules on broker-plugins directory
> ----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2531
>                 URL: https://issues.apache.org/jira/browse/QPID-2531
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Sorin Suciu
>            Assignee: Martin Ritchie
>
> The qpid broker ant build system could be improved to automatically build the OSGI modules in the broker-plugins directory given we might have multiple modules. For this, we could modify the current build.xml file from broker-plugins to delegate the tasks to each individual module via a subant task. Each module would have its own build.xml file (which would be pretty much generic). 
> So the task of adding a new OSGI module would involve: 
> - creating a new directory (eg myplugin) having a generic build.xml and the code in src subdir
> - adding the new directory to the subant task so it will be build
> - updating the build.deps file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org