You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/01 00:48:01 UTC
[jira] [Work logged] (HIVE-23606) LLAP: Delay In DirectByteBuffer
Clean Up For EncodedReaderImpl
[ https://issues.apache.org/jira/browse/HIVE-23606?focusedWorklogId=476941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476941 ]
ASF GitHub Bot logged work on HIVE-23606:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/20 00:47
Start Date: 01/Sep/20 00:47
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #1057:
URL: https://github.com/apache/hive/pull/1057#issuecomment-684124206
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 476941)
Time Spent: 20m (was: 10m)
> LLAP: Delay In DirectByteBuffer Clean Up For EncodedReaderImpl
> --------------------------------------------------------------
>
> Key: HIVE-23606
> URL: https://issues.apache.org/jira/browse/HIVE-23606
> Project: Hive
> Issue Type: Bug
> Components: llap
> Affects Versions: 3.0.0
> Reporter: Syed Shameerur Rahman
> Assignee: Syed Shameerur Rahman
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-23606.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> DirectByteBuffler are only cleaned up when there is Full GC or manually invoked cleaner method of DirectByteBuffer, Since full GC may take some time to kick in, In the meanwhile the native memory usage of LLAP daemon process might shoot up and this will force the YARN pmem monitor to kill the container running the daemon.
> HIVE-16180 tried to solve this problem, but the code structure got messed up after HIVE-15665
> The IdentityHashMap (toRelease) is initialized in https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java#L409 , but it is getting re-initialized inside the method getDataFromCacheAndDisk() https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java#L633 which makes it local to that method hence the original toRelease IdentityHashMap remains empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)