You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/23 18:21:26 UTC
[GitHub] [samza] alnzng opened a new pull request #1326: SAMZA-2492: Add new
deserialize function for JobGraphJson and change the scope of related
classes as public
alnzng opened a new pull request #1326: SAMZA-2492: Add new deserialize function for JobGraphJson and change the scope of related classes as public
URL: https://github.com/apache/samza/pull/1326
#### Symptom
In Samza core, `JobGraphJsonGenerator` provides the function to serialize `JobGraphJson` as plan JSON and later the config `samza.internal.execution.plan` will use this string as value.
However, it doesn't provide the deserialize function to help generate `JobGraphJson` from plan JSON string. This function is useful when you need to parse information from the config `samza.internal.execution.plan`.
#### Changes
In this PR, there are two changes made for supporting `JobGraphJson` deserialization:
1. Add new deserialize function `toJobGraphJson()`
1. Change the package scope of related classes as `public`
#### Tests
- [ ] All unit tests and integration tests are passed
#### API Changes
None
#### Upgrade Instructions
None
#### Usage Instructions
None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] alnzng commented on issue #1326: SAMZA-2492: Add new
deserialize function for JobGraphJson and change the scope of related
classes as public
Posted by GitBox <gi...@apache.org>.
alnzng commented on issue #1326: SAMZA-2492: Add new deserialize function for JobGraphJson and change the scope of related classes as public
URL: https://github.com/apache/samza/pull/1326#issuecomment-602847934
@MabelYC Seems you are looking for the same function provided in this PR, can you please help take a look at it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] Sanil15 commented on a change in pull request #1326:
SAMZA-2492: Add new deserialize function for JobGraphJson and change the
scope of related classes as public
Posted by GitBox <gi...@apache.org>.
Sanil15 commented on a change in pull request #1326: SAMZA-2492: Add new deserialize function for JobGraphJson and change the scope of related classes as public
URL: https://github.com/apache/samza/pull/1326#discussion_r403320866
##########
File path: samza-core/src/main/java/org/apache/samza/execution/JobGraphJsonGenerator.java
##########
@@ -44,9 +45,9 @@
/**
* This class generates the JSON representation of the {@link JobGraph}.
*/
-/* package private */ class JobGraphJsonGenerator {
+public class JobGraphJsonGenerator {
Review comment:
Since we are making them public, lets add some java docs for all the Pojo's and there use
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services