You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scholarsmate (via GitHub)" <gi...@apache.org> on 2023/05/04 01:20:27 UTC
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
scholarsmate commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184448604
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
"type": "integer",
"description": "Editor server default port",
"default": 9000
},
- "dataEditor.logFile": {
+ "dataEditorLogFile": {
"type": "string",
"description": "Path to log file for data editor",
"default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
},
- "dataEditor.logLevel": {
+ "dataEditorLogLevel": {
Review Comment:
Should this just be `logLevel`?
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
"type": "integer",
"description": "Editor server default port",
"default": 9000
},
- "dataEditor.logFile": {
+ "dataEditorLogFile": {
Review Comment:
Should this just be `logFile`?
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
Review Comment:
Should this just be `omegaEditPort`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org