[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1756: Add gethrtime() and dummy getrlimit() setrlimit(), add some dependency

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #1756:
URL: https://github.com/apache/incubator-nuttx/pull/1756#discussion_r488416941



##########
File path: include/termios.h
##########
@@ -248,6 +250,13 @@ struct termios
   tcflag_t  c_cflag;        /* Control modes */
   tcflag_t  c_lflag;        /* Local modes */
   cc_t      c_cc[NCCS];     /* Control chars */
+
+  /* Implementation specific fields.  For portability reasons, these fields
+   * should not be accessed directly, but rather through only through the
+   * cf[set|get][o|i]speed() POSIX interfaces.
+   */
+
+  speed_t c_speed;          /* Input/output speed (non-POSIX) */

Review comment:
       Revert the change, which is removed by PR https://github.com/apache/incubator-nuttx/pull/1767

##########
File path: include/cxx/cunistd
##########
@@ -71,7 +71,9 @@ namespace std
 
   // Terminal I/O
 
+#ifdef CONFIG_SERIAL_TERMIOS

Review comment:
       let's move this change to patch "include/termios.h: undefine symbols when !CONFIG_SERIAL_TERMIOS"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org