You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2017/11/03 12:20:21 UTC
spark git commit: [SPARK-22407][WEB-UI] Add rdd id column on storage
page to speed up navigating
Repository: spark
Updated Branches:
refs/heads/master 2fd12af43 -> 51145f137
[SPARK-22407][WEB-UI] Add rdd id column on storage page to speed up navigating
## What changes were proposed in this pull request?
Add rdd id column on storage page to speed up navigating.
Example has attached on [SPARK-22407](https://issues.apache.org/jira/browse/SPARK-22407)
An example below:
## How was this patch tested?
Current unit test and manually deploy an history server for testing
Author: zhoukang <zh...@gmail.com>
Closes #19625 from caneGuy/zhoukang/add-rddid.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/51145f13
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/51145f13
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/51145f13
Branch: refs/heads/master
Commit: 51145f13768ec04c14762397527b1bc2648e2374
Parents: 2fd12af
Author: zhoukang <zh...@gmail.com>
Authored: Fri Nov 3 12:20:17 2017 +0000
Committer: Sean Owen <so...@cloudera.com>
Committed: Fri Nov 3 12:20:17 2017 +0000
----------------------------------------------------------------------
.../main/scala/org/apache/spark/ui/storage/StoragePage.scala | 2 ++
.../scala/org/apache/spark/ui/storage/StoragePageSuite.scala | 7 ++++---
2 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/51145f13/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala b/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
index aa84788..b6c764d 100644
--- a/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
@@ -49,6 +49,7 @@ private[ui] class StoragePage(parent: StorageTab) extends WebUIPage("") {
/** Header fields for the RDD table */
private val rddHeader = Seq(
+ "ID",
"RDD Name",
"Storage Level",
"Cached Partitions",
@@ -60,6 +61,7 @@ private[ui] class StoragePage(parent: StorageTab) extends WebUIPage("") {
private def rddRow(rdd: RDDInfo): Seq[Node] = {
// scalastyle:off
<tr>
+ <td>{rdd.id}</td>
<td>
<a href={"%s/storage/rdd?id=%s".format(UIUtils.prependBaseUri(parent.basePath), rdd.id)}>
{rdd.name}
http://git-wip-us.apache.org/repos/asf/spark/blob/51145f13/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala b/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
index 350c174..4a48b3c 100644
--- a/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
+++ b/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
@@ -57,6 +57,7 @@ class StoragePageSuite extends SparkFunSuite {
val xmlNodes = storagePage.rddTable(Seq(rdd1, rdd2, rdd3))
val headers = Seq(
+ "ID",
"RDD Name",
"Storage Level",
"Cached Partitions",
@@ -67,19 +68,19 @@ class StoragePageSuite extends SparkFunSuite {
assert((xmlNodes \\ "tr").size === 3)
assert(((xmlNodes \\ "tr")(0) \\ "td").map(_.text.trim) ===
- Seq("rdd1", "Memory Deserialized 1x Replicated", "10", "100%", "100.0 B", "0.0 B"))
+ Seq("1", "rdd1", "Memory Deserialized 1x Replicated", "10", "100%", "100.0 B", "0.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(0) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
Some("http://localhost:4040/storage/rdd?id=1"))
assert(((xmlNodes \\ "tr")(1) \\ "td").map(_.text.trim) ===
- Seq("rdd2", "Disk Serialized 1x Replicated", "5", "50%", "0.0 B", "200.0 B"))
+ Seq("2", "rdd2", "Disk Serialized 1x Replicated", "5", "50%", "0.0 B", "200.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(1) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
Some("http://localhost:4040/storage/rdd?id=2"))
assert(((xmlNodes \\ "tr")(2) \\ "td").map(_.text.trim) ===
- Seq("rdd3", "Disk Memory Serialized 1x Replicated", "10", "100%", "400.0 B", "500.0 B"))
+ Seq("3", "rdd3", "Disk Memory Serialized 1x Replicated", "10", "100%", "400.0 B", "500.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(2) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
Some("http://localhost:4040/storage/rdd?id=3"))
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org