You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/26 11:10:54 UTC

[GitHub] [incubator-seatunnel] zhuangchong opened a new pull request, #2271: [Improvement][Common].gitignore file adds log keyword to ignore.

zhuangchong opened a new pull request, #2271:
URL: https://github.com/apache/incubator-seatunnel/pull/2271

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   .gitignore file adds log keyword to ignore.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2271: [Improvement][Common].gitignore file adds log keyword to ignore.

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2271:
URL: https://github.com/apache/incubator-seatunnel/pull/2271#issuecomment-1196249840

   > > Under what circumstances will these files appear? I haven't encountered this situation so far.
   > 
   > The log file will be generated in the seatunnel-server module.
   
   Got it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] zhuangchong commented on pull request #2271: [Improvement][Common].gitignore file adds log keyword to ignore.

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #2271:
URL: https://github.com/apache/incubator-seatunnel/pull/2271#issuecomment-1196248389

   > Under what circumstances will these files appear? I haven't encountered this situation so far.
   
   The log file will be generated in the seatunnel-server module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2271: [Improvement][Common].gitignore file adds log keyword to ignore.

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2271:
URL: https://github.com/apache/incubator-seatunnel/pull/2271#issuecomment-1196241351

   Under what circumstances will these files appear? I haven't encountered this situation so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2271: [Improvement][Common].gitignore file adds log keyword to ignore.

Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2271:
URL: https://github.com/apache/incubator-seatunnel/pull/2271


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org