[GitHub] [cassandra] adelapena commented on a change in pull request #1533: CASSANDRA-17499 Remove global Guardrails Enable flag

[GitBox <gi...@apache.org>]

adelapena commented on a change in pull request #1533:
URL: https://github.com/apache/cassandra/pull/1533#discussion_r839500973



##########
File path: src/java/org/apache/cassandra/db/guardrails/GuardrailsConfig.java
##########
@@ -46,13 +46,6 @@
  */
 public interface GuardrailsConfig
 {
-    /**
-     * Whether guardrails are enabled or not.
-     *
-     * @return {@code true} if guardrails are enabled, {@code false} otherwise
-     */
-    boolean getEnabled();

Review comment:
       There is a comment mentioning the global enable/disable flag it the class' JavaDoc, [here](https://github.com/apache/cassandra/blob/26861b173f172b663a86e03a835ac03038be13d1/src/java/org/apache/cassandra/db/guardrails/GuardrailsConfig.java#L33-L34), that should be updated. It could be updated to something like `This contains individual settings to control each guardrail.`. That same comment also exists on [`GuardrailsOptions`](https://github.com/apache/cassandra/blob/26861b173f172b663a86e03a835ac03038be13d1/src/java/org/apache/cassandra/config/GuardrailsOptions.java#L45-L46).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org