[GitHub] [maven-invoker] slawekjaranowski commented on a diff in pull request #58: [MSHARED-1151] Upgrade parent to version 38

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #58:
URL: https://github.com/apache/maven-invoker/pull/58#discussion_r1044218133


##########
pom.xml:
##########
@@ -103,21 +103,6 @@ under the License.
   </dependencies>
 
   <build>
-    <pluginManagement>

Review Comment:
   We need overide checkstyle configuration, please look at:  https://issues.apache.org/jira/browse/MPOM-371
   
   Please check site output for checkstyle report, after:
   
   ```
   mvn site -P reporting
   ```
   



##########
.git-blame-ignore-revs:
##########
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Change maven code style
+354a1c24661e50e0a61ab8e6c47b27119f49e506

Review Comment:
   I afraid that this will change after PR merge - even with rebase
   We need it in separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org