You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/08/05 18:25:10 UTC
[PR] fix(ci): Fix build and test of nanoarrow on centos7 [arrow-nanoarrow]
paleolimbot opened a new pull request, #576:
URL: https://github.com/apache/arrow-nanoarrow/pull/576
Noted in the weekly verification run: https://github.com/apache/arrow-nanoarrow/actions/runs/10232042714/job/28308701770
I think there were a two issues:
- The bundling setup used a feature of the command execution not available in stock `cmake3` on centos7
- Some C++17 in some of the newer IPC additions
Reproducible via:
```shell
export NANOARROW_PLATFORM=centos7
docker compose run -e TEST_PYTHON=0 -e TEST_R=0 --rm verify
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): Fix build and test of nanoarrow on centos7 and s390x [arrow-nanoarrow]
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz commented on code in PR #576:
URL: https://github.com/apache/arrow-nanoarrow/pull/576#discussion_r1705816905
##########
src/nanoarrow/ipc/encoder.c:
##########
@@ -395,7 +395,11 @@ ArrowErrorCode ArrowIpcEncoderEncodeSchema(struct ArrowIpcEncoder* encoder,
FLATCC_RETURN_UNLESS_0(Message_header_Schema_start(builder));
- FLATCC_RETURN_UNLESS_0(Schema_endianness_add(builder, ArrowIpcSystemEndianness()));
Review Comment:
:face_exhaling:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): Fix build and test of nanoarrow on centos7 and s390x [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #576:
URL: https://github.com/apache/arrow-nanoarrow/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org