You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Mike Percy (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 20:24:59 UTC
[jira] [Created] (FLUME-958) Miscellaneous build improvements
Miscellaneous build improvements
--------------------------------
Key: FLUME-958
URL: https://issues.apache.org/jira/browse/FLUME-958
Project: Flume
Issue Type: Improvement
Components: Build
Affects Versions: v1.0.0
Reporter: Mike Percy
Assignee: Mike Percy
Priority: Minor
Fix For: v1.1.0
There are a few things that could be improved with the build:
1. Add correct prefixes to the SCM URLs in the POM
2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
3. Generate aggregated javadocs for the multi-module project for use on the maven site
It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-958) Miscellaneous build improvements
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203904#comment-13203904 ]
jiraposter@reviews.apache.org commented on FLUME-958:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3809/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
1. Update the SCM URL to have the correct prefix per http://maven.apache.org/scm/subversion.html
2. Generate aggregated javadocs (across the sub-modules) at package time
3. Run Rat at test time instead of verify time so that it will always run (typically, you would only run the verify phase if you did an mvn install or deploy)
This addresses bug FLUME-958.
https://issues.apache.org/jira/browse/FLUME-958
Diffs
-----
pom.xml e4b40ab
Diff: https://reviews.apache.org/r/3809/diff
Testing
-------
Tested this patch on pristine source + FLUME-957.
1. SCM URL change: "mvn site" no longer fails (note however that the generated site is not used by the Flume project)
2. Javadocs: aggregated javadocs are generated by "mvn package"
3. Rat: "mvn package" leaves rat.txt files in the respective target/ subdirs of the sub-modules, evidence that it has run. Note that it succeeds only if the FLUME-957 patch has been applied.
Thanks,
Mike
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-958) Miscellaneous build improvements
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205030#comment-13205030 ]
Hudson commented on FLUME-958:
------------------------------
Integrated in flume-728 #107 (See [https://builds.apache.org/job/flume-728/107/])
FLUME-958. Miscellaneous build improvements.
(Mike Percy via Arvind Prabhakar)
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1242565
Files :
* /incubator/flume/branches/flume-728/pom.xml
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
> Attachments: flume-958.patch
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-958) Miscellaneous build improvements
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203903#comment-13203903 ]
jiraposter@reviews.apache.org commented on FLUME-958:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3809/
-----------------------------------------------------------
(Updated 2012-02-08 19:51:57.869986)
Review request for Flume.
Changes
-------
Adding FLUME-957 as parent diff. Hope this is the right way to do it.
Summary
-------
1. Update the SCM URL to have the correct prefix per http://maven.apache.org/scm/subversion.html
2. Generate aggregated javadocs (across the sub-modules) at package time
3. Run Rat at test time instead of verify time so that it will always run (typically, you would only run the verify phase if you did an mvn install or deploy)
This addresses bug FLUME-958.
https://issues.apache.org/jira/browse/FLUME-958
Diffs (updated)
-----
pom.xml e4b40ab
Diff: https://reviews.apache.org/r/3809/diff
Testing
-------
Tested this patch on pristine source + FLUME-957.
1. SCM URL change: "mvn site" no longer fails (note however that the generated site is not used by the Flume project)
2. Javadocs: aggregated javadocs are generated by "mvn package"
3. Rat: "mvn package" leaves rat.txt files in the respective target/ subdirs of the sub-modules, evidence that it has run. Note that it succeeds only if the FLUME-957 patch has been applied.
Thanks,
Mike
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-958) Miscellaneous build improvements
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-958:
-----------------------------
Attachment: flume-958.patch
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
> Attachments: flume-958.patch
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-958) Miscellaneous build improvements
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-958:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed. Thanks Mike!
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
> Attachments: flume-958.patch
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-958) Miscellaneous build improvements
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204953#comment-13204953 ]
jiraposter@reviews.apache.org commented on FLUME-958:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3809/#review4994
-----------------------------------------------------------
Ship it!
+1. Please attach the patch to the jira.
- Arvind
On 2012-02-08 19:51:57, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-08 19:51:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1. Update the SCM URL to have the correct prefix per http://maven.apache.org/scm/subversion.html
bq. 2. Generate aggregated javadocs (across the sub-modules) at package time
bq. 3. Run Rat at test time instead of verify time so that it will always run (typically, you would only run the verify phase if you did an mvn install or deploy)
bq.
bq.
bq. This addresses bug FLUME-958.
bq. https://issues.apache.org/jira/browse/FLUME-958
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml e4b40ab
bq.
bq. Diff: https://reviews.apache.org/r/3809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested this patch on pristine source + FLUME-957.
bq.
bq. 1. SCM URL change: "mvn site" no longer fails (note however that the generated site is not used by the Flume project)
bq. 2. Javadocs: aggregated javadocs are generated by "mvn package"
bq. 3. Rat: "mvn package" leaves rat.txt files in the respective target/ subdirs of the sub-modules, evidence that it has run. Note that it succeeds only if the FLUME-957 patch has been applied.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-958) Miscellaneous build improvements
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-958:
-----------------------------
Status: Patch Available (was: Open)
> Miscellaneous build improvements
> --------------------------------
>
> Key: FLUME-958
> URL: https://issues.apache.org/jira/browse/FLUME-958
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.1.0
>
> Attachments: flume-958.patch
>
>
> There are a few things that could be improved with the build:
> 1. Add correct prefixes to the SCM URLs in the POM
> 2. Run Rat in the test phase instead of the verify phase (verify is not run when "mvn package" is executed) so we don't have to deal with last minute license issues at release time
> 3. Generate aggregated javadocs for the multi-module project for use on the maven site
> It seems to make more sense to lump these smaller issues into one jira, especially since only the top-level pom.xml needs to be patched.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira