You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/31 01:14:33 UTC
[GitHub] [hbase] saintstack commented on a change in pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0
saintstack commented on a change in pull request #2825:
URL: https://github.com/apache/hbase/pull/2825#discussion_r550368884
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc
HBaseFsck.createLockRetryCounterFactory(this.conf).create());
} finally {
if (result != null) {
- IOUtils.closeQuietly(result.getSecond());
+ Closeables.close(result.getSecond(), true);
Review comment:
IOUtils.closeQuietly is also deprecated with a long time -- https://github.com/apache/commons-io/commit/ce2b3e87bfd15ba14b9e0c162e2b9c9549e1f3a8
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc
HBaseFsck.createLockRetryCounterFactory(this.conf).create());
} finally {
if (result != null) {
- IOUtils.closeQuietly(result.getSecond());
+ Closeables.close(result.getSecond(), true);
Review comment:
As is Closeables#closeQuietly... https://github.com/google/guava/issues/1118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org