You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/19 18:35:52 UTC

[GitHub] [airflow] jrowen commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

jrowen commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator
URL: https://github.com/apache/airflow/pull/5900#discussion_r348098115
 
 

 ##########
 File path: airflow/contrib/operators/awsbatch_operator.py
 ##########
 @@ -62,6 +62,10 @@ class AWSBatchOperator(BaseOperator):
         containerOverrides (templated):
         http://boto3.readthedocs.io/en/latest/reference/services/batch.html#submit_job
     :type overrides: dict
+    :param parameters: the same parameter that boto3 will receive on
+        parameters (templated):
+        http://boto3.readthedocs.io/en/latest/reference/services/batch.html#submit_job
 
 Review comment:
   Seems that `flake8` doesn't like the new url.  Is there a way to bypass this error?
   ```
   airflow/contrib/operators/awsbatch_operator.py:62:111: E501 line too long (130 > 110 characters)
   airflow/contrib/operators/awsbatch_operator.py:66:111: E501 line too long (130 > 110 characters)
   airflow/contrib/operators/awsbatch_operator.py:70:111: E501 line too long (130 > 110 characters)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services