[GitHub] sdedic commented on a change in pull request #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.
URL: https://github.com/apache/incubator-netbeans/pull/514#discussion_r184893099
 
 

 ##########
 File path: editor.lib2/src/org/netbeans/modules/editor/lib2/highlighting/HighlightingManager.java
 ##########
 @@ -241,6 +245,7 @@ synchronized HighlightsLayer findLayer(HighlightsContainer container) {
 
         public @Override void propertyChange(PropertyChangeEvent evt) {
             if (evt.getPropertyName() == null || PROP_DOCUMENT.equals(evt.getPropertyName())) {
+                updatePaneFilter();
 
 Review comment:
   What about synchronizaton on the paneFilter member variable ? It seems to be read under document read lock, what if other thread runs rebuildAllLayersImpl ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists