You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2016/03/08 03:59:12 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/265
APEXCORE-374 - Block with positive reference count is found during buffer server purge.
@PramodSSImmaneni @tweise Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core APEXCORE-374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #265
----
commit df8a9300b9b6b08aa7f9633bccbcf0bdfdbc6e81
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2016-03-08T02:30:12Z
APEXCORE-374 - Block with positive reference count is found during buffer server purge.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/265#issuecomment-193896030
Looks good from my side as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/265#issuecomment-193893016
@vrozov rest looks good. Let me know when it is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/265#issuecomment-193900899
@tweise Please merge after Travis build is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/265#discussion_r55378575
--- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/LogicalNode.java ---
@@ -93,7 +88,7 @@ public String getGroup()
*
* @return Iterator<SerializedData>
--- End diff --
fix javadoc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/265#discussion_r55378492
--- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/LogicalNode.java ---
@@ -346,7 +346,9 @@ public void boot(EventLoop eventloop)
@Override
public String toString()
{
- return "LogicalNode{" + "upstream=" + upstream + ", group=" + group + ", partitions=" + partitions + ", iterator=" + iterator + '}';
+ return getClass().getName() + "@" + Integer.toHexString(hashCode()) +
--- End diff --
Use getSimpleName instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/265#discussion_r55402374
--- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/LogicalNode.java ---
@@ -346,7 +346,9 @@ public void boot(EventLoop eventloop)
@Override
public String toString()
{
- return "LogicalNode{" + "upstream=" + upstream + ", group=" + group + ", partitions=" + partitions + ", iterator=" + iterator + '}';
+ return getClass().getName() + "@" + Integer.toHexString(hashCode()) +
--- End diff --
To avoid extra processing done by getSimpleName(), I hardcoded name to be LogicalNode. There are classes that extend LogicalNode, so this should be OK as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/265#discussion_r55391551
--- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/LogicalNode.java ---
@@ -346,7 +346,9 @@ public void boot(EventLoop eventloop)
@Override
public String toString()
{
- return "LogicalNode{" + "upstream=" + upstream + ", group=" + group + ", partitions=" + partitions + ", iterator=" + iterator + '}';
+ return getClass().getName() + "@" + Integer.toHexString(hashCode()) +
--- End diff --
You will find that many toString implementations use the short name as it is sufficient to convey the required information.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-374 - Block with positi...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/265#discussion_r55391080
--- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/LogicalNode.java ---
@@ -346,7 +346,9 @@ public void boot(EventLoop eventloop)
@Override
public String toString()
{
- return "LogicalNode{" + "upstream=" + upstream + ", group=" + group + ", partitions=" + partitions + ", iterator=" + iterator + '}';
+ return getClass().getName() + "@" + Integer.toHexString(hashCode()) +
--- End diff --
Object toString() uses getName().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---