[jira] [Commented] (HBASE-16535) Use regex to exclude generated classes for findbugs

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451046#comment-15451046 ] 

Duo Zhang commented on HBASE-16535:
-----------------------------------

Test locally with

{noformat}
mvn clean compile findbugs:findbugs
{noformat}

before
{noformat}
     [java] Warnings generated: 93
     [java] Warnings generated: 1
     [java] Warnings generated: 1
     [java] Warnings generated: 1
{noformat}

after
{noformat}
     [java] Warnings generated: 1
     [java] Warnings generated: 1
     [java] Warnings generated: 1
{noformat}

The all findbugs warnings of hbase-protocol are gone. There are still 3 warnings remaining for hbase-common, hbase-hadoop2-compat and hbase-prefix-tree. We could file a issue to fix them.

> Use regex to exclude generated classes for findbugs
> ---------------------------------------------------
>
>                 Key: HBASE-16535
>                 URL: https://issues.apache.org/jira/browse/HBASE-16535
>             Project: HBase
>          Issue Type: Bug
>          Components: findbugs
>    Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 0.98.21, 1.2.3
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 0.98.22, 1.1.7, 1.2.4
>
>         Attachments: HBASE-16535.patch
>
>
> As I tried in HBASE-16526,
> {noformat}
>   <Match>
>     <Package name="org.apache.hadoop.hbase.ipc.protobuf.generated"/>
>   </Match>
> {noformat}
> This does not work.
> So I propose that we can use regex to match the class name to exclude the generated classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)