You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/07 12:16:46 UTC
[GitHub] [airflow] GuillaumeDesforges opened a new pull request #12880: Fix setup.py missing comma (1.10.14rc3)
GuillaumeDesforges opened a new pull request #12880:
URL: https://github.com/apache/airflow/pull/12880
Fix 1.10.14rc3 setup.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739892870
And I will have to double check the constraints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739892501
Oh GAD AGAIN.... @kaxil -> sounds like rc4 :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739909095
Cn you also merge the breeze PR with it to stable @kaxil :) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739898501
Since this is only in setup_requires we _may_ be lucky and find this doesn't actually break much of anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739902946
> Doesn't seem to have actually broken anything for me.
ufff!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739908390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] GuillaumeDesforges commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
GuillaumeDesforges commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739905237
The package built without the fix, but some other libs that parse the requirements were failing (e.g. using https://github.com/DavHau/mach-nix)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739882255
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739909095
Cn you also merge the breeze fix with it to stable @kaxil :) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739909638
BTW. There is the extra space as well in the second place where docutils are mentioned
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739900742
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739908936
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739899288
```
clean-airflow-1.10.14 ❯ pip install https://dist.apache.org/repos/dist/dev/airflow/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
Collecting https://dist.apache.org/repos/dist/dev/airflow/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
Downloading https://dist.apache.org/repos/dist/dev/airflow/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz (4.1 MB)
...
Building wheels for collected packages: apache-airflow
Building wheel for apache-airflow (setup.py) ... done
Created wheel for apache-airflow: filename=apache_airflow-1.10.14-py2.py3-none-any.whl size=4715270 sha256=021bf424f21d9a2980a0105d0d55b962463e060e90f74d28db45524955bd354b
Stored in directory: /home/ash/.cache/pip/wheels/9f/a3/1d/37323222afda37226454756a8700a4ce0f19461a7f9303175f
Successfully built apache-airflow
Installing collected packages: sqlalchemy, MarkupSafe, Mako, python-editor, six, python-dateutil, alembic, zipp, importlib-metadata, argcomplete, attrs, cached-property, colorlog, configparser, natsort, croniter, dill, idna, dnspython, email-validator, jinja2, werkzeug, click, itsdangerous, flask, wtforms, flask-admin, flask-caching, flask-login, PyYAML, flask-swagger, flask-wtf, funcsigs, future, graphviz, gunicorn, importlib-resources, iso8601, json-merge-patch, pyrsistent, jsonschema, lazy-object-proxy, markdown, pyparsing, packaging, numpy, pytz, pandas, pytzdata, tzlocal, pendulum, psutil, pygments, docutils, lockfile, python-daemon, text-unidecode, python-slugify, python-nvd3, setproctitle, tabulate, tenacity, thrift, unicodecsv, zope.deprecation, typing-extensions, cattrs, pycparser, cffi, cryptography, chardet, urllib3, certifi, requests, sqlalchemy-jsonfield, sqlalchemy-utils, Flask-SQLAlchemy, Babel, Flask-Babel, marshmallow, prison, PyJWT, Flask-JWT-Extended, apispec, m
arshmallow-sqlalchemy, defusedxml, python3-openid, Flask-OpenID, colorama, marshmallow-enum, flask-appbuilder, apache-airflow
Successfully installed Babel-2.9.0 Flask-Babel-1.0.0 Flask-JWT-Extended-3.25.0 Flask-OpenID-1.2.5 Flask-SQLAlchemy-2.4.4 Mako-1.1.3 MarkupSafe-1.1.1 PyJWT-1.7.1 PyYAML-5.3.1 alembic-1.4.3 apache-airflow-1.10.14 apispec-1.3.3 argcomplete-1.12.2 attrs-20.3.0 cached-property-1.5.2 cattrs-1.1.2 certifi-2020.12.5 cffi-1.14.4 chardet-3.0.4 click-7.1.2 colorama-0.4.4 colorlog-4.0.2 configparser-3.5.3 croniter-0.3.36 cryptography-3.2.1 defusedxml-0.6.0 dill-0.3.3 dnspython-2.0.0 docutils-0.16 email-validator-1.1.2 flask-1.1.2 flask-admin-1.5.4 flask-appbuilder-2.3.4 flask-caching-1.3.3 flask-login-0.4.1 flask-swagger-0.2.14 flask-wtf-0.14.3 funcsigs-1.0.2 future-0.18.2 graphviz-0.15 gunicorn-20.0.4 idna-2.10 importlib-metadata-2.1.1 importlib-resources-1.5.0 iso8601-0.1.13 itsdangerous-1.1.0 jinja2-2.11.2 json-merge-patch-0.2 jsonschema-3.2.0 lazy-object-proxy-1.4.3 lockfile-0.12.2 markdown-2.6.11 marshmallow-2.21.0 marshmallow-enum-1.5.1 marshmallow-sqlalchemy-0.23.1 natsort-7.1.0 numpy-
1.19.4 packaging-20.7 pandas-1.1.4 pendulum-1.4.4 prison-0.1.3 psutil-5.7.3 pycparser-2.20 pygments-2.7.3 pyparsing-2.4.7 pyrsistent-0.17.3 python-daemon-2.2.4 python-dateutil-2.8.1 python-editor-1.0.4 python-nvd3-0.15.0 python-slugify-4.0.1 python3-openid-3.2.0 pytz-2020.4 pytzdata-2020.1 requests-2.23.0 setproctitle-1.2.1 six-1.15.0 sqlalchemy-1.3.20 sqlalchemy-jsonfield-0.9.0 sqlalchemy-utils-0.36.8 tabulate-0.8.7 tenacity-4.12.0 text-unidecode-1.3 thrift-0.13.0 typing-extensions-3.7.4.3 tzlocal-1.5.1 unicodecsv-0.14.1 urllib3-1.25.11 werkzeug-0.16.1 wtforms-2.3.3 zipp-3.4.0 zope.deprecation-4.4.0
WARNING: You are using pip version 20.2.4; however, version 20.3.1 is available.
You should consider upgrading via the '/home/ash/.virtualenvs/clean-airflow-1.10.14/bin/python -m pip install --upgrade pip' command.
pip install 37.21s user 3.42s system 90% cpu 44.937 total
```
Doesn't seem to have actually broken anything for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739908276
Just talked with Ash, this won't be an issue for Airflow users but we will create rc4 with the fix since this is supposed to be a bridge release and we haven't lost a good amount of time yet after rc3. Creating it now.
Thanks for reporting and fixing @GuillaumeDesforges
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12880:
URL: https://github.com/apache/airflow/pull/12880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739913363
Just opened a PR to add/enable the pylint option to check for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739910148
> Cn you also merge the breeze fix with it to stable @kaxil :) ?
yup will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12880: Fix setup.py missing comma (1.10.14rc3)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12880:
URL: https://github.com/apache/airflow/pull/12880#issuecomment-739910934
And another BTW. I checked and it has no impact on 20.3 bug (in case you asked :D)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org