You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/11/18 19:01:38 UTC
[GitHub] zeppelin pull request #1658: [WIP] [ZEPPELIN-212] Multiple paragraph results
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1658
[WIP] [ZEPPELIN-212] Multiple paragraph results
### What is this PR for?
Currently a paragraph can display only a single type of result.
For example
```
print("""
%text textout
%html htmlout
""")
```
will display only last display system detected, "htmlout".
This pr implements multiple results supports, so not only the last, but also all the display systems in a paragraph outputs can be displayed.
To do that, Note.json format need to be changed. from
```
paragraph : [
{
result : {
code: "",
type: "",
msg: ""
},
config : {
graph : {},
...
},
...
},
...
],
...
```
to
```
paragraph : [
{
result : {
{
code: "",
msg: [
{
type: "",
data: ""
},
{
type: "",
data: ""
}
]
},
config : {
result : [
{
graph : {},
},
{
graph : {},
},
...
]
},
...
},
...
],
...
```
### What type of PR is it?
Improvement
### Todos
* [x] - Make InterpreterResult and InterpreterOutput support multiple display system
* [x] - Automatic migration old format to new format
* [ ] - Render multiple results in front-end
* [ ] - Take care Importing old notebook format
* [ ] - Make helium framework support multiple results
* [ ] - Save note in old format in some notebook repo (zeppelinhubrepo)
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-212
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? yes
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-212
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1658.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1658
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1658
tried locally and works as expected, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1658
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1658
I think this PR is ready to be reviewed.
While this PR includes quite a lot of changes i'm highlighting some key changes.
1. Display multiple types of output in a single paragraph.
Previously, if output includes multiple display system directive (e.g. %html, %text, etc) only the last one was effective and all the previous output was ignored. After the change, a paragraph sequentially display all display system directive in the output result.
To do that, on the front-end side,
Created ResultCtrl controller under `zeppelin-web/src/app/notebook/paragraph/result`
and moved paragraph result rendering related scripts/templates under this directory.
/notebook/paragraph/paragraph-graph.html -> /notebook/paragraph/result/result-graph.html
/notebook/paragraph/paragraph-pivot.html -> /notebook/paragraph/result/result-pivot.html
/notebook/paragraph/paragraph-result.html -> /notebook/paragraph/result/result-results.html
/notebook/paragraph/paragraph-chart-selector.html -> /notebook/paragraph/result/result-chart-selector.html
on the back-end side,
Created `zeppelin-interpreter/interpreter/InterpreterResultMessageOutput.java` to take care of single output stream and existing `zeppelin-interpreter/interpreter/InterpreterResultMessageOutput.java` changed to take care of multiple outputs through `InterpreterResultMessageOutput`
2. Compatibility between old, new notebook format.
note.json format is changed to store multiple outputs in the paragraph.
To read note.json created by previous versions of Zeppelin, [Notebook.convertFromSingleResultToMultipleResultsFormat()](https://github.com/apache/zeppelin/blob/7ab6679a87ed75f176ffa61d8cf6c73f4241c528/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java#L385) will automatically convert format when note.json is loaded in Zeppelin.
If old version of Zeppelin reads notebook created by newer version, everything will be load normally except for output. Output will be empty.
In detail, note.json is changed from
```
paragraph : [
{
result : {
code: "",
type: "",
msg: ""
},
config : {
graph : {},
...
},
...
},
...
],
...
```
to
```
paragraph : [
{
results : {
{
code: "",
msg: [
{
type: "",
data: ""
},
{
type: "",
data: ""
},
...
]
},
config : {
results : [
{
graph : {},
},
{
graph : {},
},
...
]
},
...
},
...
],
...
```
3. Every other changes are trivial
Most changes are trivial change due to change of InterpreterOutput and InterpreterResult api changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1658
Very nice @Leemoonsoo \U0001f44d
I have tested this with the matplotlib tutorial notebook just to see if [ZEPPELIN-1638](https://issues.apache.org/jira/browse/ZEPPELIN-1638) is also resolved by this, and everything checks out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1658
Thanks @agoodm @khalidhuseynov for the review!
Merge to master if there're no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1658
@Leemoonsoo FYI, #1632 added another set of tests. The interpreter result format for these should be changed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1658
@agoodm merged master and addressed tests added from #1632.
CI failure is not related. Merge to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---