[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1127911487


##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -230,15 +229,12 @@ public List<SolrPackageInstance> fetchInstalledPackageInstances() throws SolrExc
   public Map<String, SolrPackageInstance> getPackagesDeployed(String collection) {
     Map<String, String> packages = null;
     try {
-      Map<String, String[]> paramsMap = new LinkedHashMap<>();
-      paramsMap.put("omitHeader", new String[] {"true"});
-      paramsMap.put("wt", new String[] {"javabin"});
       NamedList<Object> result =
           solrClient.request(
               new GenericSolrRequest(
                   SolrRequest.METHOD.GET,
                   PackageUtils.getCollectionParamsPath(collection) + "/PKG_VERSIONS",
-                  new ModifiableSolrParams(paramsMap)));
+                  new ModifiableSolrParams().add("omitHeader", "true").add("wt", "javabin")));

Review Comment:
   Nicer!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org