You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/03 05:39:01 UTC

[GitHub] [superset] zhoulijuanmiao opened a new pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

zhoulijuanmiao opened a new pull request #19006:
URL: https://github.com/apache/superset/pull/19006


   …negative value
   
   fixed the bug #18996 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1057914442


   @zhoulijuanmiao Thanks for the fix! I will test it in my local environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao edited a comment on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao edited a comment on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1058696523


   > Hi @zhoulijuanmiao, Could you double-check this PR? I haven't got any change on the PR.
   > 
   > ![image](https://user-images.githubusercontent.com/2016594/156572990-1995d3c5-b76e-4cc2-923d-04eb4ee69a0b.png)
   @zhaoyongjie before i fixed it, the chart was looked like this，could you ignore my change in local environment and check again?
   ![Screen Shot 2022-03-02 at 5 26 39 PM](https://user-images.githubusercontent.com/23090803/156675441-7bcc7dbe-042e-49a8-8a39-fb527766639a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1059633314


   hi @zhaoyongjie, Thanks for your check, seems like I need to explain the pr a bit more specific, as you can see, before my pr, there is a feature of how to show bar value labels, **negative value showing on the bottom of the bar, positive value showing on the top of the bar**.
   
   **The rule is satisfied in unstacked bar chart, to see it clearly, I set filters in all pictures below**
   
   ![Screen Shot 2022-03-05 at 8 25 18 AM](https://user-images.githubusercontent.com/23090803/156859143-1990831e-3b31-4bc2-8372-ac0aeabf1b09.png)
   
   ![Screen Shot 2022-03-05 at 8 07 19 AM](https://user-images.githubusercontent.com/23090803/156858566-a7f55ab2-978d-40ee-908e-966e5666676c.png)
   
   **But the rule is not satisfied in stacked bar chart**, my purpose is to fix it
   
   ![Screen Shot 2022-03-05 at 8 07 00 AM](https://user-images.githubusercontent.com/23090803/156860354-5bcb5c23-1a4e-43cb-a0a8-0d4cb6b8bc36.png)
   
   **After my pr, the rule will be satisfied in stacked bar chart, additionally, this may make the viz looks better**
   
   ![Screen Shot 2022-03-05 at 8 38 07 AM](https://user-images.githubusercontent.com/23090803/156860083-8d5b83c8-4703-4f4f-999e-f306b03a1582.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1072119153


   @zhaoyongjie hi, any progress?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1058696523


   > Hi @zhoulijuanmiao, Could you double-check this PR? I haven't got any change on the PR.
   > 
   > ![image](https://user-images.githubusercontent.com/2016594/156572990-1995d3c5-b76e-4cc2-923d-04eb4ee69a0b.png)
   
   before i fixed it, the chart was looked like this，could you ignore my change in local environment and check again?
   ![Screen Shot 2022-03-02 at 5 26 39 PM](https://user-images.githubusercontent.com/23090803/156675441-7bcc7dbe-042e-49a8-8a39-fb527766639a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1072119153


   @zhaoyongjie hi, any progress?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1058036876


   Hi @zhoulijuanmiao, Could you double-check this PR? I haven't got any change on the PR.
   
   ![image](https://user-images.githubusercontent.com/2016594/156572990-1995d3c5-b76e-4cc2-923d-04eb4ee69a0b.png)
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao edited a comment on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao edited a comment on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1058696523


   hi @zhaoyongjie, before i fixed it, the chart was looked like this，could you ignore my change in local environment and check again?
   ![Screen Shot 2022-03-02 at 5 26 39 PM](https://user-images.githubusercontent.com/23090803/156675441-7bcc7dbe-042e-49a8-8a39-fb527766639a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1059198002


   Hi @zhoulijuanmiao, Thanks for your fix, and I have checked in your PR. Currently, the viz looks good. But it looks like there is an issue(might be too short) with all the negative values in the Viz.
   
   ### After your PR
   ![image](https://user-images.githubusercontent.com/2016594/156778138-f7070ebe-c16e-4ccb-8192-985e7176340b.png)
   
   
   
   BTW, I found a workaround for showing labels is that set `x tick layout` to `staggered`.
   
   ### Before your PR
   ![image](https://user-images.githubusercontent.com/2016594/156778613-0c028da4-f270-49bd-8ab2-c604217104b8.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1057869420


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19006](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (749b760) into [master](https://codecov.io/gh/apache/superset/commit/be88cb9ba00a706dc5402e0b5311975bb013972a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be88cb9) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/19006/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #19006      +/-   ##
   ==========================================
   - Coverage   66.58%   66.57%   -0.02%     
   ==========================================
     Files        1641     1641              
     Lines       63548    63563      +15     
     Branches     6424     6424              
   ==========================================
   + Hits        42312    42315       +3     
   - Misses      19555    19569      +14     
   + Partials     1681     1679       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `51.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...tend/plugins/legacy-preset-chart-nvd3/src/utils.js](https://codecov.io/gh/apache/superset/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3V0aWxzLmpz) | `14.53% <0.00%> (-1.39%)` | :arrow_down: |
   | [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `79.39% <0.00%> (+1.81%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [be88cb9...749b760](https://codecov.io/gh/apache/superset/pull/19006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhoulijuanmiao commented on pull request #19006: fix(chart): STACKED BARS VALUES did not show correctly when data has …

Posted by GitBox <gi...@apache.org>.
zhoulijuanmiao commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1057712136


   @villebro hi, are you available to review the code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org