You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/22 19:42:23 UTC

[GitHub] [pulsar] srkukarni commented on a change in pull request #6801: [functions] Don't auth functions worker metrics endpoint

srkukarni commented on a change in pull request #6801:
URL: https://github.com/apache/pulsar/pull/6801#discussion_r429425569



##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -99,6 +99,17 @@
         doc = "The port for serving worker https requests"
     )
     private Integer workerPortTls;
+    @FieldContext(
+            category = CATEGORY_WORKER,
+            doc = "Whether the '/metrics' endpoint requires authentication. Defaults to false."

Review comment:
       does it default to false or true? The doc says one and the default config says other




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org