You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2018/04/19 06:47:44 UTC
[GitHub] nifi pull request #2645: NIFI-5095: Suppress SET property parse failure at H...
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2645
NIFI-5095: Suppress SET property parse failure at Hive processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-5095
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2645.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2645
----
commit 6e31d726078d8c95bb222eb6c0f2a52b32c5611a
Author: Koji Kawamura <ij...@...>
Date: 2018-04-19T06:45:16Z
NIFI-5095: Suppress SET property parse failure at Hive processors
----
---
[GitHub] nifi issue #2645: NIFI-5095: Suppress SET property parse failure at Hive pro...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2645
@pvillard31 Thanks for pointing that. Yes, it's indirectly related to NIFI-5044. If pre/post query statement is added to SelectHiveQuery, then statements such as 'set x=y' or 'add jar..' would be written there and will not be passed to findTableNames method I assume.
However, for PutHiveQL, such queries can be bundled in the same FlowFile content. I filtered out only 'set x=y' statement, but it's not enough. 'add jar ...' fails similarly. Moreover, if we're going to filter out those commands, we need to care all commands in this wiki page I guess.
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Cli
It requires something like CommandProcessorFactory.
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java#L51
That will be overkill for this JIRA and findTableNames purpose. I will update this PR to simply lower the log level to INFO. Thanks!
---
[GitHub] nifi issue #2645: NIFI-5095: Suppress SET property parse failure at Hive pro...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2645
+1 LGTM, ran build and unit tests. Thanks for this improvement! Merging to master
---
[GitHub] nifi issue #2645: NIFI-5095: Suppress SET property parse failure at Hive pro...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2645
@ijokarumawak - could this be related to https://issues.apache.org/jira/browse/NIFI-5044 ?
If yes, then the same issue would occur with 'add jar ...' for example, right?
Based on the discussion on the JIRA, it's probably best to include two properties for pre and post query statements. Thoughts?
---
[GitHub] nifi pull request #2645: NIFI-5095: Suppress SET property parse failure at H...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2645
---