You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/12/11 11:51:46 UTC
[GitHub] [commons-bcel] nbauma109 opened a new pull request, #188: Verifier: test and coverage for SWAP instruction
nbauma109 opened a new pull request, #188:
URL: https://github.com/apache/commons-bcel/pull/188
Eclipse compiler is useful to generate specific .class file patterns.
SWAP instruction is never emitted by javac.
This PR contains a test for Verifier main method and SWAP input source file to be compiled with Eclipse Compiler (ecj) with source/target 1.4.
I included ecj version 3.26.0 which is the last JDK8-compatible version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
nbauma109 commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045247528
##########
src/test/java/org/apache/bcel/verifier/VerifierMainTestCase.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.verifier;
+
+import org.apache.bcel.AbstractTestCase;
+import org.apache.commons.lang3.StringUtils;
+import org.eclipse.jdt.internal.compiler.batch.Main;
+import org.junit.jupiter.api.Test;
+
+import java.io.BufferedInputStream;
+import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class VerifierMainTestCase extends AbstractTestCase {
+
+ @Test
+ public void testSWAP() throws Exception {
+ final String[] argv = new String[] { "src/test/java/org/apache/bcel/data/SWAP.java", "-g", "-source", "1.4", "-target", "1.4", "-d", "target/test-classes" };
+ new Main(new PrintWriter(System.out), new PrintWriter(System.err), false/*systemExit*/, null/*options*/, null/*progress*/).compile(argv);
Review Comment:
I'll update the test so that it checks for swap and update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#issuecomment-1345533472
# [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#188](https://codecov.io/gh/apache/commons-bcel/pull/188?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7be293f) into [master](https://codecov.io/gh/apache/commons-bcel/commit/56483f6fda7ae16244ffdbc11213b98bf4e28193?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56483f6) will **increase** coverage by `0.39%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #188 +/- ##
============================================
+ Coverage 61.65% 62.04% +0.39%
- Complexity 3654 3672 +18
============================================
Files 363 363
Lines 15633 15633
Branches 1950 1950
============================================
+ Hits 9638 9699 +61
+ Misses 5121 5050 -71
- Partials 874 884 +10
```
| [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...el/verifier/structurals/InstConstraintVisitor.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvc3RydWN0dXJhbHMvSW5zdENvbnN0cmFpbnRWaXNpdG9yLmphdmE=) | `37.51% <0.00%> (+0.10%)` | :arrow_up: |
| [...g/apache/bcel/verifier/statics/Pass3aVerifier.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvc3RhdGljcy9QYXNzM2FWZXJpZmllci5qYXZh) | `50.88% <0.00%> (+0.19%)` | :arrow_up: |
| [...ain/java/org/apache/bcel/generic/EmptyVisitor.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvZ2VuZXJpYy9FbXB0eVZpc2l0b3IuamF2YQ==) | `97.80% <0.00%> (+0.54%)` | :arrow_up: |
| [...ache/bcel/verifier/structurals/Pass3bVerifier.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvc3RydWN0dXJhbHMvUGFzczNiVmVyaWZpZXIuamF2YQ==) | `68.34% <0.00%> (+0.71%)` | :arrow_up: |
| [...he/bcel/verifier/structurals/ExecutionVisitor.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvc3RydWN0dXJhbHMvRXhlY3V0aW9uVmlzaXRvci5qYXZh) | `74.90% <0.00%> (+0.99%)` | :arrow_up: |
| [...in/java/org/apache/bcel/verifier/PassVerifier.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvUGFzc1ZlcmlmaWVyLmphdmE=) | `100.00% <0.00%> (+30.00%)` | :arrow_up: |
| [...c/main/java/org/apache/bcel/verifier/Verifier.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvVmVyaWZpZXIuamF2YQ==) | `81.94% <0.00%> (+61.11%)` | :arrow_up: |
| [src/main/java/org/apache/bcel/generic/SWAP.java](https://codecov.io/gh/apache/commons-bcel/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvZ2VuZXJpYy9TV0FQLmphdmE=) | `100.00% <0.00%> (+71.42%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045240156
##########
src/test/java/org/apache/bcel/data/SWAP.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.data;
+
+import java.lang.reflect.Constructor;
+
+/*
+ * A test for SWAP instruction.
+ * To be compiled with Eclipse Compiler (ecj) with source/target 1.4.
Review Comment:
Either the comment is wrong, or, the class should be in the repo. We already have plenty of class files in the repo, see src/test/resources. This component is unlike most since it works with these types of files explicitly, otherwise you would not want class files in a repo.
##########
src/test/java/org/apache/bcel/data/SWAP.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.data;
+
+import java.lang.reflect.Constructor;
+
+/*
+ * A test for SWAP instruction.
+ * To be compiled with Eclipse Compiler (ecj) with source/target 1.4.
Review Comment:
Either the comment is wrong, or, the class should be in the repo. We already have plenty of class files in the repo, see src/test/resources. This component is unlike most since it works with these types of files explicitly, otherwise, you would not want class files in a repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045232359
##########
src/test/java/org/apache/bcel/data/SWAP.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.data;
+
+import java.lang.reflect.Constructor;
+
+/*
+ * A test for SWAP instruction.
+ * To be compiled with Eclipse Compiler (ecj) with source/target 1.4.
Review Comment:
If that is really a requirement for this test fixture, then a precompiled class file should be in the test resources. Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
nbauma109 commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045236781
##########
src/test/java/org/apache/bcel/data/SWAP.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.data;
+
+import java.lang.reflect.Constructor;
+
+/*
+ * A test for SWAP instruction.
+ * To be compiled with Eclipse Compiler (ecj) with source/target 1.4.
Review Comment:
It's indeed a possibility, but I'm not a fan of committing a class file in a repo, if we update the source, the class also needs to be updated and committed too, and also when there's a class file in a repo, one always wonders where it comes from, how it was generated, if it actually matches the source code, or if it can be trusted. If pulling a dependency is more of a problem, I can commit the class instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045246490
##########
src/test/java/org/apache/bcel/verifier/VerifierMainTestCase.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.verifier;
+
+import org.apache.bcel.AbstractTestCase;
+import org.apache.commons.lang3.StringUtils;
+import org.eclipse.jdt.internal.compiler.batch.Main;
+import org.junit.jupiter.api.Test;
+
+import java.io.BufferedInputStream;
+import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class VerifierMainTestCase extends AbstractTestCase {
+
+ @Test
+ public void testSWAP() throws Exception {
+ final String[] argv = new String[] { "src/test/java/org/apache/bcel/data/SWAP.java", "-g", "-source", "1.4", "-target", "1.4", "-d", "target/test-classes" };
+ new Main(new PrintWriter(System.out), new PrintWriter(System.err), false/*systemExit*/, null/*options*/, null/*progress*/).compile(argv);
Review Comment:
Except that the test passes when complied without EJC, so at least I think the test should be better documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #188:
URL: https://github.com/apache/commons-bcel/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
nbauma109 commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045241405
##########
src/test/java/org/apache/bcel/verifier/VerifierMainTestCase.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.verifier;
+
+import org.apache.bcel.AbstractTestCase;
+import org.apache.commons.lang3.StringUtils;
+import org.eclipse.jdt.internal.compiler.batch.Main;
+import org.junit.jupiter.api.Test;
+
+import java.io.BufferedInputStream;
+import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class VerifierMainTestCase extends AbstractTestCase {
+
+ @Test
+ public void testSWAP() throws Exception {
+ final String[] argv = new String[] { "src/test/java/org/apache/bcel/data/SWAP.java", "-g", "-source", "1.4", "-target", "1.4", "-d", "target/test-classes" };
+ new Main(new PrintWriter(System.out), new PrintWriter(System.err), false/*systemExit*/, null/*options*/, null/*progress*/).compile(argv);
Review Comment:
This line answers that requirement "To be compiled with Eclipse Compiler (ecj) with source/target 1.4."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #188: Verifier: test and coverage for SWAP instruction
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #188:
URL: https://github.com/apache/commons-bcel/pull/188#discussion_r1045248198
##########
src/test/java/org/apache/bcel/verifier/VerifierMainTestCase.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.verifier;
+
+import org.apache.bcel.AbstractTestCase;
+import org.apache.commons.lang3.StringUtils;
+import org.eclipse.jdt.internal.compiler.batch.Main;
+import org.junit.jupiter.api.Test;
+
+import java.io.BufferedInputStream;
+import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class VerifierMainTestCase extends AbstractTestCase {
+
+ @Test
+ public void testSWAP() throws Exception {
+ final String[] argv = new String[] { "src/test/java/org/apache/bcel/data/SWAP.java", "-g", "-source", "1.4", "-target", "1.4", "-d", "target/test-classes" };
+ new Main(new PrintWriter(System.out), new PrintWriter(System.err), false/*systemExit*/, null/*options*/, null/*progress*/).compile(argv);
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org