You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2024/09/15 13:24:09 UTC
[PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
jonkeane opened a new pull request, #44124:
URL: https://github.com/apache/arrow/pull/44124
### Rationale for this change
Add two distros not checked on CRAN to our allow list for easier binary installs
### What changes are included in this PR?
Added to distro names
### Are these changes tested?
These configurations are tested elsewhere, the real test will come later if CRAN somehow runs these covertly
### Are there any user-facing changes?
Faster, more reliably installs without intervention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #44124:
URL: https://github.com/apache/arrow/pull/44124#discussion_r1760162765
##########
r/tools/nixlibs.R:
##########
@@ -222,7 +222,7 @@ check_allowlist <- function(os, allowed = "https://raw.githubusercontent.com/apa
# Try a remote allowlist so that we can add/remove without a release
suppressWarnings(readLines(allowed)),
# Fallback to default: allowed only on Ubuntu and CentOS/RHEL
- error = function(e) c("ubuntu", "centos", "redhat", "rhel")
+ error = function(e) c("ubuntu", "centos", "redhat", "rhel", "rocky", "opensuse-leap")
Review Comment:
I don't recall the history on this, but the local copy of the allowlist should be present here, right? Can we fall back to `readLines("nixlibs-allowlist.txt")` (or whatever path it is relative to cwd)? That way we only have to track this in one place.
Also we should update the comment on the line above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #44124:
URL: https://github.com/apache/arrow/pull/44124#discussion_r1769636600
##########
r/tools/nixlibs.R:
##########
@@ -222,7 +222,7 @@ check_allowlist <- function(os, allowed = "https://raw.githubusercontent.com/apa
# Try a remote allowlist so that we can add/remove without a release
suppressWarnings(readLines(allowed)),
# Fallback to default: allowed only on Ubuntu and CentOS/RHEL
- error = function(e) c("ubuntu", "centos", "redhat", "rhel")
+ error = function(e) c("ubuntu", "centos", "redhat", "rhel", "rocky", "opensuse-leap")
Review Comment:
Ah, of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44124:
URL: https://github.com/apache/arrow/pull/44124#issuecomment-2351592260
:warning: GitHub issue #44114 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #44124:
URL: https://github.com/apache/arrow/pull/44124#issuecomment-2365283747
> but with `any(grepl(paste(allowlist, collapse = "|"), os))` `opensuse` should cover `opensuse-leap` and any future versions if I'm not mistaken
Ah, right right. Ok I've changed it to `opensuse`. It would be good to have confirmation of what the possible values are there, in case we need to add something like `open-suse` or `opensus3` or something. But this should be good for the issue at hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #44124:
URL: https://github.com/apache/arrow/pull/44124#issuecomment-2351616364
Is there a reason to be specific with `-leap`? Or do we want just `opensuse` to be ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #44124:
URL: https://github.com/apache/arrow/pull/44124#issuecomment-2351645238
> Is there a reason to be specific with -leap? Or do we want just opensuse to be ok?
I discovered this when chatting with someone from the Posit Package Manager, and that's the string they got when they ran the `distro` code. But this might be an issue with `distro`, or maybe `opensuse` has different flavors? Or also possible that the Posit Package Manager folks are using a slightly non-standard build of opensuse. Do you know of any references for which to look for? I'm happy to add it, but I think we would need both to catch the system that they seem to be using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #44124:
URL: https://github.com/apache/arrow/pull/44124#issuecomment-2351649085
I see but with `any(grepl(paste(allowlist, collapse = "|"), os))` `opensuse` should cover `opensuse-leap` and any future versions if I'm not mistaken (not at a pc right now to test it^^)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44114: [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44124:
URL: https://github.com/apache/arrow/pull/44124#issuecomment-2401166198
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0707c0495f71418fde19249e7d7be8b0b0f6a5f5.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/31270654928) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org