You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/24 22:20:13 UTC
[GitHub] [shardingsphere] Liangda-w opened a new pull request #9809: Add the SQL definition ALTER SYNONYM of Oracle database
Liangda-w opened a new pull request #9809:
URL: https://github.com/apache/shardingsphere/pull/9809
Relates #6480
Changes proposed in this pull request:
- Add SQL definition of ALTER SYNONYM
- Add new test cases
Former discussion #9740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #9809: Add the SQL definition ALTER SYNONYM of Oracle database
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9809:
URL: https://github.com/apache/shardingsphere/pull/9809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9809: Add the SQL definition ALTER SYNONYM of Oracle database
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9809:
URL: https://github.com/apache/shardingsphere/pull/9809#issuecomment-810037039
Hi @Liangda-w ,
I saw the approval from @wgy8283335 , but unfortunately, some conflict files appear, could you have a look?
BTW, GSoC 2021 is on the student register stage now, where you can begin to consider your application, I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on pull request #9809: Add the SQL definition ALTER SYNONYM of Oracle database
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #9809:
URL: https://github.com/apache/shardingsphere/pull/9809#issuecomment-809860563
@tristaZero I've finished the review， shall we merge this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #9809: Add the SQL definition ALTER SYNONYM of Oracle database
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #9809:
URL: https://github.com/apache/shardingsphere/pull/9809#issuecomment-810949241
Hi @tristaZero, I've resolved the conflict:)
Thank you for the kind reminder! I'm on the way to complete my GSoC proposal and will send you for a review once I finish it😄
@wgy8283335 Thank you for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9809: Add the SQL definition ALTER SYNONYM of Oracle database
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9809:
URL: https://github.com/apache/shardingsphere/pull/9809#issuecomment-806441115
Nice @Liangda-w
Hi @wgy8283335 , Could you give this PR a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org