You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/12 13:06:00 UTC
[jira] [Commented] (FLINK-8420) Timeout exceptions are not properly
recognized by RetryingRegistration
[ https://issues.apache.org/jira/browse/FLINK-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323918#comment-16323918 ]
ASF GitHub Bot commented on FLINK-8420:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5286
[FLINK-8420] [flip6] Recognize TimeoutException in RetryingRegistration
## What is the purpose of the change
A timeout exception will trigger an exponential backoff wrt the connection timeout.
This will guarantee that we don't overload the network with connection requests but
also to quickly connect to a newly available target.
## Verifying this change
- Covered by `RetryingRegistrationTest#testRetriesOnTimeouts`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixRetryingRegistrationTimeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5286
----
commit 08a4788572de57b9878c95b45d6c2a0256691a4f
Author: Till Rohrmann <tr...@...>
Date: 2018-01-03T12:25:09Z
[FLINK-8340] [flip6] Remove passing of Configuration to CustomCommandLine
Since the Configuration does not change over the lifetime of a CustomCommandLine,
we can safely pass it as a constructor argument instead of method argument.
This closes #5226.
commit 20bf4f179239c9e29bad75433859f45738b260fe
Author: Till Rohrmann <tr...@...>
Date: 2017-12-20T15:32:18Z
[FLINK-8341] [flip6] Remove not needed options from CommandLineOptions
This closes #5227.
commit 142c17025f77bc4e1be72d998a25b3701d33acec
Author: Till Rohrmann <tr...@...>
Date: 2018-01-02T09:19:34Z
[FLINK-8342] [flip6] Remove generic type parameter from ClusterDescriptor
This closes #5228.
commit 59381f67cdc4f70b33bf2d3664aea57dc90c6b83
Author: Till Rohrmann <tr...@...>
Date: 2018-01-11T22:25:58Z
[FLINK-8349] [flip6] Remove Yarn specific commands from YarnClusterDescriptor
Remove Yarn specific commands from YarnClusterDescriptor. This is a preparational
step to make the FlinkYarnSessionCli work with the Flip-6 RestClusterClient.
This closes #5229.
commit fda194860382131cf91b839b1543fb367e3856f0
Author: Till Rohrmann <tr...@...>
Date: 2017-12-29T14:12:46Z
[hotfix] Add help command to FlinkYarnSessionCli
commit ac34a6183d96c202c6a221173d50613fbb46ec7b
Author: Till Rohrmann <tr...@...>
Date: 2018-01-11T22:46:33Z
[FLINK-8347] [flip6] Make cluster id used by ClusterDescriptor typesafe
The ClusterDescriptor uses a typed cluster id for the ClusterClient retrieval.
Moreover, the ClusterClient and the CustomCommandLine are typed accordingly.
This closes #5232.
commit ad69f50ea2c7f77aa528086c080691338913fd34
Author: Till Rohrmann <tr...@...>
Date: 2017-12-29T14:29:06Z
[FLINK-8348] [flip6] Print help for DefaultCLI
This closes #5233.
commit af4eec90d07a9170aa4a71e2c98ec6e317e2100f
Author: Till Rohrmann <tr...@...>
Date: 2018-01-03T19:38:21Z
[FLINK-8119] [flip6] Wire correct Flip6 components in Flip6YarnClusterDescriptor
Let the Flip6YarnClusterDescriptor create a RestClusterClient as ClusterClient.
Moreover, this commit makes the YarnResourceManager register under the REST port
at Yarn.
This closes #5234.
commit 793120f2d6e199fe9f8cd0fce2df7eeabc7cfdcc
Author: Till Rohrmann <tr...@...>
Date: 2017-12-29T16:08:45Z
[hotfix] Log failure message only if Yarn application truly failed
commit 00024cf1e81b16d9d4f134649240852ed1e79cf0
Author: wenlong.lwl <we...@...>
Date: 2017-12-05T07:54:39Z
[FLINK-8201] [yarn] Delete temp configuration file after uploading it to HDFS
The Utils#createTaskExecutorContext method creates a temporary local configuration
file which it then uploads to HDFS. This fille should be removed after the upload
has completed.
This closes #5123.
commit b4295546ceaa0eed651ea373fe47cdefab597cd5
Author: Till Rohrmann <tr...@...>
Date: 2018-01-12T13:02:05Z
[FLINK-8420] [flip6] Recognize TimeoutException in RetryingRegistration
A timeout exception will trigger an exponential backoff wrt the connection timeout.
This will guarantee that we don't overload the network with connection requests but
also to quickly connect to a newly available target.
----
> Timeout exceptions are not properly recognized by RetryingRegistration
> ----------------------------------------------------------------------
>
> Key: FLINK-8420
> URL: https://issues.apache.org/jira/browse/FLINK-8420
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RetryingRegistration}} does not correctly respond to {{TimeoutExceptions}} and instead treats them like errors. This causes that it waits for the delay on error instead of backing exponentially off.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)