[GitHub] HyukjinKwon commented on a change in pull request #23709: [SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but in-memory while the SparkContext exists

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23709: [SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but in-memory while the SparkContext exists
URL: https://github.com/apache/spark/pull/23709#discussion_r252921293
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
 ##########
 @@ -36,29 +36,41 @@ import org.apache.spark.sql.internal.StaticSQLConf._
 import org.apache.spark.status.ElementTrackingStore
 import org.apache.spark.util.{MutableURLClassLoader, Utils}
 
-
 /**
  * A class that holds all state shared across sessions in a given [[SQLContext]].
  */
-private[sql] class SharedState(val sparkContext: SparkContext) extends Logging {
+private[sql] class SharedState(val sparkContext: SparkContext, initConfig: Map[String, String])
+  extends Logging {
+  private val conf = sparkContext.conf.clone()
+  private val hadoopConf = new Configuration(sparkContext.hadoopConfiguration)
 
 Review comment:
   we can even do:
   
   
   ```scala
   private val (conf, hadoopConf) = {
     val clonedConf = sparkContext.conf.clone()
     val clonedHadoopConf = new Configuration(sparkContext.hadoopConfiguration)
     // If `SparkSession` is instantiated using an existing `SparkContext` instance and no existing
     // `SharedState`, all `SparkSession` level configurations have higher priority to generate a
     // `SharedState` instance. This will be done only once then shared across `SparkSession`s
     // See SPARK-26794.
     initConfig.foreach { case (k, v) =>
       logDebug(s"Applying initiate SparkSession options to SparkConf/HadoopConf: $k -> $v")
       conf.set(k, v)
       hadoopConf.set(k, v)
     }
     logDebug("Applied all initiate SparkSession options to the brand new SharedState")
     (clonedConf, clonedHadoopConf)
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org