You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/27 04:20:58 UTC

[GitHub] [spark] LuciferYang commented on pull request #35666: [SPARK-38338][BUILD][CORE] Remove test dependency on `hamcrest`

LuciferYang commented on pull request #35666:
URL: https://github.com/apache/spark/pull/35666#issuecomment-1053094775


   On the other hand, we can use `assertj` instead of `hamcrest`. It seems that `assertj`  is also popular and  it declares that it supports Java 17 after `3.21.0` at the same time:
   
   - https://mvnrepository.com/artifact/org.assertj/assertj-core
   - https://assertj.github.io/doc/#assertj-core-3-21-0-release-notes
   
   cc @dongjoon-hyun @srowen 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org