You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/25 05:41:05 UTC

[GitHub] [apisix] hnlq715 opened a new pull request #4892: docs: improve zipkin plugin

hnlq715 opened a new pull request #4892:
URL: https://github.com/apache/apisix/pull/4892


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr commented on a change in pull request #4892: docs: improve zipkin plugin

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4892:
URL: https://github.com/apache/apisix/pull/4892#discussion_r696343415



##########
File path: docs/en/latest/plugins/zipkin.md
##########
@@ -31,7 +31,7 @@ title: Zipkin
 
 ## Name
 
-[Zipkin](https://github.com/openzipkin/zipkin) is a OpenTracing plugin.
+`zipkin` is a plugin for [Zipkin](https://github.com/openzipkin/zipkin), which is a distributed tracing system.

Review comment:
       Yes, Zipkin is not an implementation of OpenTracing. It is also its plugins. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr commented on a change in pull request #4892: docs: improve zipkin plugin

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4892:
URL: https://github.com/apache/apisix/pull/4892#discussion_r696343415



##########
File path: docs/en/latest/plugins/zipkin.md
##########
@@ -31,7 +31,7 @@ title: Zipkin
 
 ## Name
 
-[Zipkin](https://github.com/openzipkin/zipkin) is a OpenTracing plugin.
+`zipkin` is a plugin for [Zipkin](https://github.com/openzipkin/zipkin), which is a distributed tracing system.

Review comment:
       Yes, Zipkin is not an implementation of OpenTracing. It is also not its plugins. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on pull request #4892: docs: improve zipkin plugin

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on pull request #4892:
URL: https://github.com/apache/apisix/pull/4892#issuecomment-905362550


   ![image](https://user-images.githubusercontent.com/1734615/130771290-09635e98-ead4-47d5-91ba-697e1a073d31.png)
   
   This pr was intended to uniform the title naming style, maybe it's just a kind of obsessive-compulsive disorder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 closed pull request #4892: docs: improve zipkin plugin

Posted by GitBox <gi...@apache.org>.
hnlq715 closed pull request #4892:
URL: https://github.com/apache/apisix/pull/4892


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] hnlq715 commented on pull request #4892: docs: improve zipkin plugin

Posted by GitBox <gi...@apache.org>.
hnlq715 commented on pull request #4892:
URL: https://github.com/apache/apisix/pull/4892#issuecomment-906144576


   Recently I have been combing through the apisix documentation. 
   Generally, I will give feedback when I find a problem. Of course, it is your choice whether to accept it or not :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on pull request #4892: docs: improve zipkin plugin

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4892:
URL: https://github.com/apache/apisix/pull/4892#issuecomment-906140179


   Smart people like you should focus on advanced issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org