You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/07 14:33:11 UTC
[GitHub] [solr] risdenk opened a new pull request, #1001: SOLR-16405: Remove unneeded errorprone suppressions
risdenk opened a new pull request, #1001:
URL: https://github.com/apache/solr/pull/1001
https://issues.apache.org/jira/browse/SOLR-16405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1001:
URL: https://github.com/apache/solr/pull/1001#issuecomment-1240923591
So in commit 02cecd6731874465537e5b688cfcf1d0e60f5503, I finally found a log2m value that gives some accurate enough results for testing. I am beasting this test to make sure all is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1001:
URL: https://github.com/apache/solr/pull/1001#issuecomment-1239792082
I think this found a potentially real bug in:
```
TestDistributedStatsComponentCardinality
> java.lang.AssertionError: int_i: relativeErr=0.09722718241315029, estimate=4746, real=5337, p=q=id_i1:[4807+TO+10143]&rows=0&stats=true&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8}int_i&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8+hllPreHashed%3Dtrue}int_i_prehashed_l&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8}long_l&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8+hllPreHashed%3Dtrue}long_l_prehashed_l&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8}string_s&stats.field={!cardinality%3Dtrue+hllLog2m%3D7+hllRegwidth%3D8+hllPreHashed%3Dtrue}string_s_prehashed_l
> at __randomizedtesting.SeedInfo.seed([FEAEB9079F935BD9:76FA86DD316F3621]:0)
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.apache.solr.handler.component.TestDistributedStatsComponentCardinality.test(TestDistributedStatsComponentCardinality.java:179)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1001:
URL: https://github.com/apache/solr/pull/1001#issuecomment-1239892447
> I think the above error is actually https://issues.apache.org/jira/browse/SOLR-10918
ehhh it might be related - but running `./gradlew -p solr/core beast -Ptests.dups=10 --tests "org.apache.solr.handler.component.TestDistributedStatsComponentCardinality"` still fails when putting that failing assert inside the SOLR-10918 if statement...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1001:
URL: https://github.com/apache/solr/pull/1001#issuecomment-1239744487
My methodology is super suspect, I checked out `main`, and looked the java errors in intelliJ, then I checked out this branch, and looked at the java errors in intelliJ. We went from 27,544 warnings to 27,448 warnings. So this has my +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1001:
URL: https://github.com/apache/solr/pull/1001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1001:
URL: https://github.com/apache/solr/pull/1001#issuecomment-1239884621
I think the above error is actually https://issues.apache.org/jira/browse/SOLR-10918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org