You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/18 11:09:47 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #106: Introduce the clock mock to test block controller
hanahmily opened a new pull request, #106:
URL: https://github.com/apache/skywalking-banyandb/pull/106
This tends to introduce a clock mock to convince the tsdb block controller testing.
* Add a mock clock to mock `time` package.
* Remove the `millisecond` interval time unit which is only for testing.
fixes https://github.com/apache/skywalking/issues/8844
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #106: Introduce the clock mock to test block controller
Posted by GitBox <gi...@apache.org>.
hanahmily merged PR #106:
URL: https://github.com/apache/skywalking-banyandb/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #106: Introduce the clock mock to test block controller
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #106:
URL: https://github.com/apache/skywalking-banyandb/pull/106#discussion_r852054365
##########
banyand/tsdb/tsdb_suite_test.go:
##########
@@ -34,6 +34,6 @@ func TestTsdb(t *testing.T) {
var _ = BeforeSuite(func() {
Expect(logger.Init(logger.Logging{
Env: "dev",
- Level: "info",
+ Level: "debug",
Review Comment:
Shall we revert this back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #106: Introduce the clock mock to test block controller
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #106:
URL: https://github.com/apache/skywalking-banyandb/pull/106#discussion_r852054365
##########
banyand/tsdb/tsdb_suite_test.go:
##########
@@ -34,6 +34,6 @@ func TestTsdb(t *testing.T) {
var _ = BeforeSuite(func() {
Expect(logger.Init(logger.Logging{
Env: "dev",
- Level: "info",
+ Level: "debug",
Review Comment:
Shall we revert this back? `DEBUG` may be too noisy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org