You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Jochen Kemnade (JIRA)" <ji...@apache.org> on 2016/12/27 10:14:58 UTC

[jira] [Commented] (TAP5-2567) CSSURLRewriter throws RuntimeException if asset not found, instead evaluating strictCssUrlRewriting

    [ https://issues.apache.org/jira/browse/TAP5-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780096#comment-15780096 ] 

Jochen Kemnade commented on TAP5-2567:
--------------------------------------

Ideally, CSSURLRewriter should not try to rewrite URLs in comments.

> CSSURLRewriter throws RuntimeException if asset not found, instead evaluating strictCssUrlRewriting
> ---------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2567
>                 URL: https://issues.apache.org/jira/browse/TAP5-2567
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4.1
>            Reporter: Robert Hannebauer
>         Attachments: CSSURLRewriter-TAP5-2567.patch
>
>
> If the css header comment part contains a pattern like 'url(file_not_found)' the procedure AssetSource.getAsset throws an RuntimeException and prevents further processing, especially testing for null and evaluating StrictCSSURLRewriting.
> Caused by: java.lang.RuntimeException: Unable to locate asset 'webjars:META-INF/resources/webjars/jquery-ui/1.12.1/%22images%2Fui-icons_555555_256x240.png%22'
> (the file does not exist).
>     at org.apache.tapestry5.internal.services.AssetSourceImpl.getLocalizedAssetFromResource(AssetSourceImpl.java:390)
>     at org.apache.tapestry5.internal.services.AssetSourceImpl.getAssetInLocale(AssetSourceImpl.java:305)
>     at org.apache.tapestry5.internal.services.AssetSourceImpl.getAsset(AssetSourceImpl.java:131)
>     at $AssetSource_25dc8e7415b4a.getAsset(Unknown Source)
>     at org.apache.tapestry5.internal.services.assets.CSSURLRewriter.replaceURLs(CSSURLRewriter.java:177)
>     at org.apache.tapestry5.internal.services.assets.CSSURLRewriter.access$100(CSSURLRewriter.java:46)
>     at org.apache.tapestry5.internal.services.assets.CSSURLRewriter$1.perform(CSSURLRewriter.java:109)
>     at org.apache.tapestry5.internal.services.assets.CSSURLRewriter$1.perform(CSSURLRewriter.java:104)
>     at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:110)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)