You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "jinchengchenghh (via GitHub)" <gi...@apache.org> on 2025/09/10 00:06:11 UTC

[I] Fix cudf build in velox [incubator-gluten]

jinchengchenghh opened a new issue, #10663:
URL: https://github.com/apache/incubator-gluten/issues/10663

   ### Problem description
   
   This command failed
   make -j EXTRA_CMAKE_FLAGS="-DVELOX_ENABLE_GPU=ON -DVELOX_ENABLE_CUDF=ON -DCMAKE_CUDA_ARCHITECTURES=70 -DCMAKE_CUDA_COMPILER=/usr/local/cuda-12.8/bin/nvcc -DVELOX_ENABLE_SPARK_FUNCTIONS=ON"
   ```
   velox_cudf_parquet_connector.dir/ParquetDataSink.cpp.o -c /opt/velox/velox/experimental/cudf/connectors/parquet/ParquetDataSink.cpp
   In file included from /opt/velox/./velox/common/config/Config.h:25,
                    from /opt/velox/./velox/experimental/cudf/connectors/parquet/ParquetConfig.h:19,
                    from /opt/velox/velox/experimental/cudf/connectors/parquet/ParquetDataSink.cpp:17:
   /opt/velox/velox/experimental/cudf/connectors/parquet/ParquetDataSink.cpp: In constructor 'facebook::velox::cudf_velox::connector::parquet::ParquetDataSink::ParquetDataSink(facebook::velox::RowTypePtr, std::shared_ptr<const facebook::velox::cudf_velox::connector::parquet::ParquetInsertTableHandle>, const facebook::velox::connector::ConnectorQueryCtx*, facebook::velox::connector::CommitStrategy, const std::shared_ptr<const facebook::velox::cudf_velox::connector::parquet::ParquetConfig>&)':
   /opt/velox/velox/experimental/cudf/connectors/parquet/ParquetDataSink.cpp:145:7: error: 'commitStrategyToString' was not declared in this scope; did you mean 'commitStrategy_'?
     145 |       commitStrategyToString(commitStrategy_));
         |       ^~~~~~~~~~~~~~~~~~~~~~
   /opt/velox/./velox/common/base/Exceptions.h:136:52: note: in definition of macro '_VELOX_THROW_IMPL'
     136 |     auto message = ::facebook::velox::errorMessage(__VA_ARGS__);      \
         |                                                    ^~~~~~~~~~~
   /opt/velox/./velox/common/base/Exceptions.h:223:3: note: in expansion of macro '_VELOX_CHECK_AND_THROW_IMPL'
     223 |   _VELOX_CHECK_AND_THROW_IMPL(                                   \
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   /opt/velox/./velox/common/base/Exceptions.h:342:3: note: in expansion of macro '_VELOX_USER_CHECK_IMPL'
     342 |   _VELOX_USER_CHECK_IMPL(expr, #expr, ##__VA_ARGS__)
         |   ^~~~~~~~~~~~~~~~~~~~~~
   /opt/velox/velox/experimental/cudf/connectors/parquet/ParquetDataSink.cpp:141:3: note: in expansion of macro 'VELOX_USER_CHECK'
     141 |   VELOX_USER_CHECK(
   
   
   VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -DFOLLY_CFG_NO_COROUTINES -Wall -Wextra -Wno-unused        -Wno-unused-parameter        -Wno-sign-compare        -Wno-ignored-qualifiers        -Wno-implicit-fallthrough          -Wno-class-memaccess          -Wno-comment          -Wno-int-in-bool-context          -Wno-redundant-move          -Wno-array-bounds          -Wno-maybe-uninitialized          -Wno-unused-result          -Wno-format-overflow          -Wno-strict-aliasing -Wno-restrict -Werror -O3 -DNDEBUG -std=gnu++20 -fPIC -fdiagnostics-color=always -MD -MT velox/experimental/cudf/tests/utils/CMakeFiles/velox_cudf_exec_test_lib.dir/CudfPlanBuilder.cpp.o -MF velox/experimental/cudf/tests/utils/CMakeFiles/velox_cudf_exec_test_lib.dir/CudfPlanBuilder.cpp.o.d -o velox/experimental/cudf/tests/utils/CMakeFiles/velox_cudf_exec_test_lib.dir/CudfPlanBuilder.cpp.o -c /opt/velox/velox/experimental/cudf/tests/utils/CudfPlanBuilder.cpp
   /opt/velox/velox/experimental/cudf/tests/utils/CudfPlanBuilder.cpp: In lambda function:
   /opt/velox/velox/experimental/cudf/tests/utils/CudfPlanBuilder.cpp:40:38: error: cannot convert 'const std::shared_ptr<facebook::velox::core::AggregationNode>' to 'const std::optional<facebook::velox::core::ColumnStatsSpec>&'
      40 |         TableWriteTraits::outputType(aggregationNode),
         |                                      ^~~~~~~~~~~~~~~
         |                                      |
         |                                      const std::shared_ptr<facebook::velox::core::AggregationNode>
   In file included from /opt/velox/velox/experimental/cudf/tests/utils/CudfPlanBuilder.cpp:20:
   /opt/velox/./velox/exec/TableWriter.h:80:51: note:   initializing argument 1 of 'static facebook::velox::RowTypePtr facebook::velox::exec::TableWriteTraits::outputType(const std::optional<facebook::velox::core::ColumnStatsSpec>&)'
      80 |       const std::optional<core::ColumnStatsSpec>& columnStatsSpec);
         |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
   /opt/velox/velox/experimental/cudf/tests/utils/CudfPlanBuilder.cpp: In lambda function:
   /opt/velox/velox/experimental/cudf/tests/utils/CudfPlanBuilder.cpp:92:38: error: cannot convert 'const std::shared_ptr<facebook::velox::core::AggregationNode>' to 'const std::optional<facebook::velox::core::ColumnStatsSpec>&'
      92 |         TableWriteTraits::outputType(aggregationNode),
         |                                      ^~~~~~~~~~~~~~~
         |                                      |
         |                                      const std::shared_ptr<facebook::velox::core::AggregationNode>
   /opt/velox/./velox/exec/TableWriter.h:80:51: note:   initializing argument 1 of 'static facebook::velox::RowTypePtr facebook::velox::exec::TableWriteTraits::outputType(const std::optional<facebook::velox::core::ColumnStatsSpec>&)'
      80 |       const std::optional<core::ColumnStatsSpec>& columnStatsSpec);
         |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
   ```
   
   ### System information
   
   /
   
   ### CMake log
   
   ```bash
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] Fix cudf build in velox [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on issue #10663:
URL: https://github.com/apache/incubator-gluten/issues/10663#issuecomment-3273965360

   https://github.com/facebookincubator/velox/pull/14799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] Fix cudf build in velox [incubator-gluten]

Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh closed issue #10663: Fix cudf build in velox
URL: https://github.com/apache/incubator-gluten/issues/10663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] Fix cudf build in velox [incubator-gluten]

Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on issue #10663:
URL: https://github.com/apache/incubator-gluten/issues/10663#issuecomment-3306765942

   https://github.com/facebookincubator/velox/pull/14811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org