You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/14 12:12:29 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5228: Support both rv32/rv64 on qemu-rv
no1wudi opened a new pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228
## Summary
* Support rv32/rv64 on single virt board
* Let ISA configuable to make evaluate NuttX on risc-v easily
## Impact
qemu-rv32 only
## Testing
CI and QEMU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784920173
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh/defconfig
##########
@@ -18,18 +18,22 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_NSH_DISABLE_PSSTACKUSAGE is not set
# CONFIG_NSH_DISABLE_UNAME is not set
-CONFIG_16550_ADDRWIDTH=32
+CONFIG_16550_ADDRWIDTH=0
CONFIG_16550_UART0=y
CONFIG_16550_UART0_BASE=0x10000000
CONFIG_16550_UART0_CLOCK=3686400
CONFIG_16550_UART0_IRQ=37
CONFIG_16550_UART0_SERIAL_CONSOLE=y
CONFIG_16550_UART=y
CONFIG_ARCH="risc-v"
-CONFIG_ARCH_BOARD="rv32-virt"
-CONFIG_ARCH_BOARD_QEMU_RV32_VIRT=y
-CONFIG_ARCH_CHIP="qemu-rv32"
+CONFIG_ARCH_BOARD="rv-virt"
+CONFIG_ARCH_BOARD_QEMU_RV_VIRT=y
+CONFIG_ARCH_CHIP="qemu-rv"
CONFIG_ARCH_CHIP_QEMU_RV32=y
+CONFIG_ARCH_CHIP_QEMU_RV=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_A=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_C=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_M=y
Review comment:
Yes, but these items are generated by savedefconfig, and need them to pass the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784992916
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh/defconfig
##########
@@ -18,18 +18,22 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_NSH_DISABLE_PSSTACKUSAGE is not set
# CONFIG_NSH_DISABLE_UNAME is not set
-CONFIG_16550_ADDRWIDTH=32
+CONFIG_16550_ADDRWIDTH=0
CONFIG_16550_UART0=y
CONFIG_16550_UART0_BASE=0x10000000
CONFIG_16550_UART0_CLOCK=3686400
CONFIG_16550_UART0_IRQ=37
CONFIG_16550_UART0_SERIAL_CONSOLE=y
CONFIG_16550_UART=y
CONFIG_ARCH="risc-v"
-CONFIG_ARCH_BOARD="rv32-virt"
-CONFIG_ARCH_BOARD_QEMU_RV32_VIRT=y
-CONFIG_ARCH_CHIP="qemu-rv32"
+CONFIG_ARCH_BOARD="rv-virt"
+CONFIG_ARCH_BOARD_QEMU_RV_VIRT=y
+CONFIG_ARCH_CHIP="qemu-rv"
CONFIG_ARCH_CHIP_QEMU_RV32=y
+CONFIG_ARCH_CHIP_QEMU_RV=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_A=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_C=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_M=y
Review comment:
if so, why not change the default from y ro n?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784914870
##########
File path: arch/risc-v/Kconfig
##########
@@ -113,8 +113,6 @@ config ARCH_CHIP_RV32M1
config ARCH_CHIP_QEMU_RV32
bool "QEMU RV32"
select ARCH_RV32
- select ARCH_RV_ISA_M
- select ARCH_RV_ISA_A
Review comment:
If so why not make ARCH_RV_ISA_F/ARCH_RV_ISA_D configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784921075
##########
File path: arch/risc-v/Kconfig
##########
@@ -113,8 +113,6 @@ config ARCH_CHIP_RV32M1
config ARCH_CHIP_QEMU_RV32
bool "QEMU RV32"
select ARCH_RV32
- select ARCH_RV_ISA_M
- select ARCH_RV_ISA_A
Review comment:
They are controlled by CONFIG_ARCH_FPU and CONFIG_ARCH_DPFPU eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r785248753
##########
File path: arch/risc-v/Kconfig
##########
@@ -113,8 +113,6 @@ config ARCH_CHIP_RV32M1
config ARCH_CHIP_QEMU_RV32
bool "QEMU RV32"
select ARCH_RV32
- select ARCH_RV_ISA_M
- select ARCH_RV_ISA_A
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784823838
##########
File path: arch/risc-v/Kconfig
##########
@@ -113,8 +113,6 @@ config ARCH_CHIP_RV32M1
config ARCH_CHIP_QEMU_RV32
bool "QEMU RV32"
select ARCH_RV32
- select ARCH_RV_ISA_M
- select ARCH_RV_ISA_A
Review comment:
why limit the ISA set if qemu always support them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784835433
##########
File path: arch/risc-v/Kconfig
##########
@@ -113,8 +113,6 @@ config ARCH_CHIP_RV32M1
config ARCH_CHIP_QEMU_RV32
bool "QEMU RV32"
select ARCH_RV32
- select ARCH_RV_ISA_M
- select ARCH_RV_ISA_A
Review comment:
Now these options moved to `qemu-rv`'s Kconfig to provide more flexiblity.
```
config ARCH_CHIP_QEMU_RV_ISA_M
bool "Standard Extension for Integer Multiplication and Division"
default y
select ARCH_RV_ISA_M
config ARCH_CHIP_QEMU_RV_ISA_A
bool "Standard Extension for Atomic Instructions"
default y
select ARCH_RV_ISA_A
config ARCH_CHIP_QEMU_RV_ISA_C
bool "Standard Extension for Compressed Instructions"
default y
select ARCH_RV_ISA_C
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784916038
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh/defconfig
##########
@@ -18,18 +18,22 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_NSH_DISABLE_PSSTACKUSAGE is not set
# CONFIG_NSH_DISABLE_UNAME is not set
-CONFIG_16550_ADDRWIDTH=32
+CONFIG_16550_ADDRWIDTH=0
CONFIG_16550_UART0=y
CONFIG_16550_UART0_BASE=0x10000000
CONFIG_16550_UART0_CLOCK=3686400
CONFIG_16550_UART0_IRQ=37
CONFIG_16550_UART0_SERIAL_CONSOLE=y
CONFIG_16550_UART=y
CONFIG_ARCH="risc-v"
-CONFIG_ARCH_BOARD="rv32-virt"
-CONFIG_ARCH_BOARD_QEMU_RV32_VIRT=y
-CONFIG_ARCH_CHIP="qemu-rv32"
+CONFIG_ARCH_BOARD="rv-virt"
+CONFIG_ARCH_BOARD_QEMU_RV_VIRT=y
+CONFIG_ARCH_CHIP="qemu-rv"
CONFIG_ARCH_CHIP_QEMU_RV32=y
+CONFIG_ARCH_CHIP_QEMU_RV=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_A=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_C=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_M=y
Review comment:
remove, the default option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r784992325
##########
File path: arch/risc-v/Kconfig
##########
@@ -113,8 +113,6 @@ config ARCH_CHIP_RV32M1
config ARCH_CHIP_QEMU_RV32
bool "QEMU RV32"
select ARCH_RV32
- select ARCH_RV_ISA_M
- select ARCH_RV_ISA_A
Review comment:
ARCH_RV_ISA_F/ARCH_RV_ISA_D is same as ARCH_HAVE_FPU/SRCH_HAVE_DFPU, should we remove the first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5228: Support both rv32/rv64 on qemu-rv
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5228:
URL: https://github.com/apache/incubator-nuttx/pull/5228#discussion_r785257665
##########
File path: boards/risc-v/qemu-rv/rv-virt/configs/nsh/defconfig
##########
@@ -18,18 +18,22 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_NSH_DISABLE_PSSTACKUSAGE is not set
# CONFIG_NSH_DISABLE_UNAME is not set
-CONFIG_16550_ADDRWIDTH=32
+CONFIG_16550_ADDRWIDTH=0
CONFIG_16550_UART0=y
CONFIG_16550_UART0_BASE=0x10000000
CONFIG_16550_UART0_CLOCK=3686400
CONFIG_16550_UART0_IRQ=37
CONFIG_16550_UART0_SERIAL_CONSOLE=y
CONFIG_16550_UART=y
CONFIG_ARCH="risc-v"
-CONFIG_ARCH_BOARD="rv32-virt"
-CONFIG_ARCH_BOARD_QEMU_RV32_VIRT=y
-CONFIG_ARCH_CHIP="qemu-rv32"
+CONFIG_ARCH_BOARD="rv-virt"
+CONFIG_ARCH_BOARD_QEMU_RV_VIRT=y
+CONFIG_ARCH_CHIP="qemu-rv"
CONFIG_ARCH_CHIP_QEMU_RV32=y
+CONFIG_ARCH_CHIP_QEMU_RV=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_A=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_C=y
+CONFIG_ARCH_CHIP_QEMU_RV_ISA_M=y
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org