[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #518: DISPATCH-1354: Annotation processing performance improvements

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #518: DISPATCH-1354: Annotation processing performance improvements
URL: https://github.com/apache/qpid-dispatch/pull/518#discussion_r291679091
 
 

 ##########
 File path: src/parse.c
 ##########
 @@ -722,61 +722,123 @@ const char *qd_parse_annotations_v1(
         return parse_error;
     }
 
+    // define a shorthand name for the qd message annotation key prefix length
+#define QMPL QD_MA_PREFIX_LEN
+
+#define MIN(a,b) (((a)<(b))?(a):(b))
 
 Review comment:
   ooh!  Please put this (and maybe MAX) into ctools.h - don't know how many times I've ended up doing this exact same thing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org