You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Anton Kalashnikov (Jira)" <ji...@apache.org> on 2022/01/05 10:29:00 UTC

[jira] [Commented] (FLINK-25105) Enables final checkpoint by default

    [ https://issues.apache.org/jira/browse/FLINK-25105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469174#comment-17469174 ] 

Anton Kalashnikov commented on FLINK-25105:
-------------------------------------------

[~gaoyunhaii], [~pnowojski], What is the status of this task? I see that PR is merged already but the ticket still is in progress. I also see that this commit is the reason for performance degradation:

----

*Before FLINK-25105*

"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit","Param: outputMode"
"org.apache.flink.benchmark.AsyncWaitOperatorBenchmark.asyncWait","thrpt",1,30,*1471.788898*,15.547273,"ops/ms",ORDERED
"org.apache.flink.benchmark.AsyncWaitOperatorBenchmark.asyncWait","thrpt",1,30,*1616.482907*,21.136931,"ops/ms",UNORDERED

"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit"
"org.apache.flink.benchmark.ContinuousFileReaderOperatorBenchmark.readFileSplit","thrpt",1,30,*32962.046509*,938.778253,"ops/ms"

*After FLINK-25105*

"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit","Param: outputMode"
"org.apache.flink.benchmark.AsyncWaitOperatorBenchmark.asyncWait","thrpt",1,30,*844.115888*,179.259249,"ops/ms",ORDERED
"org.apache.flink.benchmark.AsyncWaitOperatorBenchmark.asyncWait","thrpt",1,30,*816.532647*,171.720407,"ops/ms",UNORDERED

"Benchmark","Mode","Threads","Samples","Score","Score Error (99.9%)","Unit"
"org.apache.flink.benchmark.ContinuousFileReaderOperatorBenchmark.readFileSplit","thrpt",1,30,*30335.000281*,1027.411003,"ops/ms"

----

Is this expected degradation or not? if not then we should handle it since it is pretty significant difference.


> Enables final checkpoint by default
> -----------------------------------
>
>                 Key: FLINK-25105
>                 URL: https://issues.apache.org/jira/browse/FLINK-25105
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Checkpointing
>    Affects Versions: 1.15.0
>            Reporter: Yun Gao
>            Assignee: Yun Gao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> We would fix all the conflict tests and enable the feature by default in this version.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)