You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Gordon Sim (JIRA)" <ji...@apache.org> on 2011/04/06 13:28:05 UTC
[jira] [Created] (QPID-3190) qpid-tool does not allow numeric
strings to be passed as strings
qpid-tool does not allow numeric strings to be passed as strings
----------------------------------------------------------------
Key: QPID-3190
URL: https://issues.apache.org/jira/browse/QPID-3190
Project: Qpid
Issue Type: Bug
Components: python tools
Affects Versions: 0.10
Reporter: Gordon Sim
Assignee: Gordon Sim
E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3190) qpid-tool does not allow numeric
strings to be passed as strings
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016347#comment-13016347 ]
Gordon Sim commented on QPID-3190:
----------------------------------
Two options available for comment/review: https://reviews.apache.org/r/552/ and https://reviews.apache.org/r/553/
> qpid-tool does not allow numeric strings to be passed as strings
> ----------------------------------------------------------------
>
> Key: QPID-3190
> URL: https://issues.apache.org/jira/browse/QPID-3190
> Project: Qpid
> Issue Type: Bug
> Components: python tools
> Affects Versions: 0.10
> Reporter: Gordon Sim
> Assignee: Gordon Sim
>
> E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3190) qpid-tool does not allow numeric
strings to be passed as strings
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim resolved QPID-3190.
------------------------------
Resolution: Fixed
Option1 committed.... may still want to revisit the general approach and clean up but that can be done independent of any required fixes now.
> qpid-tool does not allow numeric strings to be passed as strings
> ----------------------------------------------------------------
>
> Key: QPID-3190
> URL: https://issues.apache.org/jira/browse/QPID-3190
> Project: Qpid
> Issue Type: Bug
> Components: python tools
> Affects Versions: 0.10
> Reporter: Gordon Sim
> Assignee: Gordon Sim
>
> E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3190) qpid-tool does not allow numeric
strings to be passed as strings
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016345#comment-13016345 ]
jiraposter@reviews.apache.org commented on QPID-3190:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/553/
-----------------------------------------------------------
(Updated 2011-04-06 11:33:26.082995)
Review request for Ted Ross.
Summary
-------
Always try to eval args, but add special case handling for unquoted strings (to keep backward compatibility - alternative would be to require strings to always be quoted).
This addresses bug QPID-3190.
https://issues.apache.org/jira/browse/QPID-3190
Diffs
-----
/trunk/qpid/tools/src/py/qpid-tool 1088930
Diff: https://reviews.apache.org/r/553/diff
Testing
-------
Thanks,
Gordon
> qpid-tool does not allow numeric strings to be passed as strings
> ----------------------------------------------------------------
>
> Key: QPID-3190
> URL: https://issues.apache.org/jira/browse/QPID-3190
> Project: Qpid
> Issue Type: Bug
> Components: python tools
> Affects Versions: 0.10
> Reporter: Gordon Sim
> Assignee: Gordon Sim
>
> E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3190) qpid-tool does not allow numeric
strings to be passed as strings
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016343#comment-13016343 ]
jiraposter@reviews.apache.org commented on QPID-3190:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/552/
-----------------------------------------------------------
Review request for Ted Ross.
Summary
-------
Simply detect tokens starting with one of the quoting chars and always eval them.
This addresses bug QPID-3190.
https://issues.apache.org/jira/browse/QPID-3190
Diffs
-----
/trunk/qpid/tools/src/py/qpid-tool 1088930
Diff: https://reviews.apache.org/r/552/diff
Testing
-------
Thanks,
Gordon
> qpid-tool does not allow numeric strings to be passed as strings
> ----------------------------------------------------------------
>
> Key: QPID-3190
> URL: https://issues.apache.org/jira/browse/QPID-3190
> Project: Qpid
> Issue Type: Bug
> Components: python tools
> Affects Versions: 0.10
> Reporter: Gordon Sim
> Assignee: Gordon Sim
>
> E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3190) qpid-tool does not allow numeric
strings to be passed as strings
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated QPID-3190:
-----------------------------
Fix Version/s: 0.11
> qpid-tool does not allow numeric strings to be passed as strings
> ----------------------------------------------------------------
>
> Key: QPID-3190
> URL: https://issues.apache.org/jira/browse/QPID-3190
> Project: Qpid
> Issue Type: Bug
> Components: python tools
> Affects Versions: 0.10
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.11
>
>
> E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org