You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/04/29 21:18:23 UTC
[tomcat] branch 7.0.x updated (9141493 -> 965f55c)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 9141493 Avoid NPE when minimal Context defined in server.xml
new 45fd227 Improve the one line formatter so it outputs the correct thread ID even when using the async log writer.
new 36f788e Fix NPE observed in testing logs
new bca6c5c Restore line incorrectly removed in r1516416 Thanks due to rjung for spotting my error
new f06ebb8 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59871 Make timestamp format of OneLineFormatter configurable
new 17afdbe Fix typo. Patch provided by Josh Soref.
new 646946f Back-port a SpotBugs fix to align the code
new 88a2324 Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63335
new 45e5714 Avoid unnecessary blank line after stack trace
new 965f55c Move changelog entries to correct location
The 11983 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
java/org/apache/juli/DateFormatCache.java | 4 +
java/org/apache/juli/OneLineFormatter.java | 173 +++++++++++++++++++++++++----
webapps/docs/changelog.xml | 18 +++
3 files changed, 173 insertions(+), 22 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Missing git commit emails
Posted by Rainer Jung <ra...@kippdata.de>.
Am 30.04.2019 um 12:07 schrieb Mark Thomas:
> On 30/04/2019 09:17, Rainer Jung wrote:
>> What could we do to avoid those summary emails, more precisely to
>> reliably get the detail emails? Currently a review via email often is
>> not possible due to the missing detail emails.
>
> I think it is related to pushing multiple commits at once.
>
> Best bet is to engage with the infra team.
Done that. Infra knew about it [1] and was already investigating with
GitHub on how to fix it.
One fix to an ASF script was applied yesterday [2] and Sebb also
recommends to only use Gitbox not Github to pull/push [3]. So if the
applied fix actualy fixes the problem, we are good, if not, we could try
switching individually to GitBox. I myself was only using GitBox,
because without reason I was assuming it to be more authoritative.
Regards,
Rainer
[1] https://issues.apache.org/jira/browse/INFRA-17931
[2]
https://gitbox.apache.org/repos/asf?p=infrastructure-puppet.git;a=commitdiff;h=a5884ae;hp=2802a7b01d15345531dcfea4c2716573357fcf89
[3]
https://lists.apache.org/thread.html/4aeb1af5e142d3abc10b5c0fb98a2b1ac0e4386fd52a1543ef6b82ad@%3Cdev.ponymail.apache.org%3E
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Missing git commit emails
Posted by Mark Thomas <ma...@apache.org>.
On 30/04/2019 09:17, Rainer Jung wrote:
> What could we do to avoid those summary emails, more precisely to
> reliably get the detail emails? Currently a review via email often is
> not possible due to the missing detail emails.
I think it is related to pushing multiple commits at once.
Best bet is to engage with the infra team.
Mark
>
> I wonder whether the occurence of these "no details, instead just a
> summary" emails has anything to do with the exact work flow of pulling
> branching and pushing on the local repos side. Or whether it has
> anything to do with us using two different git repos (at Github and
> gitbox at Apache).
>
> Sometimes it happens direct after a change of committer, sometimes the
> commits in such a block go back in time. But the one case in master
> cited below has no such obvious peculiarity. All of the commits and also
> the ones directly before and after that block come from Mark, so no
> change, the time increases monotonically:
>
> commit e0c112c514b07e5c323ca3a184fe26029e3cde4e
> Author: Mark Thomas <ma...@apache.org>
> Date: Fri Apr 26 21:56:07 2019 +0100
>
> Import update Czech translations from POEDitor
>
> BEGIN BUNDLED COMMITS
>
> commit a01cff1cc3fe5c86559c071e7941699b45ef94d5
> Author: Mark Thomas <ma...@apache.org>
> Date: Fri Apr 26 21:52:04 2019 +0100
>
> Import updated French translations
>
> commit 16ea77018aaa7bd7b0ecd69cf6bf3771be59c2c6
> Author: Mark Thomas <ma...@apache.org>
> Date: Fri Apr 26 21:51:32 2019 +0100
>
> Import updated Japanese translations from POEditor
>
> END BUNDLED COMMITS
>
> commit c3e33a090791bf3abdeead4075d403f6ab337e97
> Author: Mark Thomas <ma...@apache.org>
> Date: Fri Apr 26 20:56:27 2019 +0100
>
> Remove unused translations
>
> commit 88e03792f840bdbc2bbf07d38074823e17bff412
> Author: Mark Thomas <ma...@apache.org>
> Date: Fri Apr 26 20:55:18 2019 +0100
>
> Import updated French translations from POEditor
>
>
>
> I am sorry not to have any precise ideas currently, but I am willing to
> help eg. by exercising a couple of different work flows, using different
> repositories etc. But at the moment I don't have any good ideas about
> where to start.
>
> Thanks and regards,
>
> Rainer
>
> Am 26.04.2019 um 23:00 schrieb markt@apache.org:> This is an automated
> email from the ASF dual-hosted git repository.
>>
>> markt pushed a change to branch master
>> in repository https://gitbox.apache.org/repos/asf/tomcat.git.
>>
>>
>> from c3e33a0 Remove unused translations
>> new 16ea770 Import updated Japanese translations from POEditor
>> new a01cff1 Import updated French translations
>>
>> The 20788 revisions listed above as "new" are entirely new to this
>> repository and will be described in separate emails. The revisions
>> listed as "add" were already present in the repository and have only
>> been added to this reference.
>>
>>
>> Summary of changes:
>> java/org/apache/catalina/loader/LocalStrings_ja.properties | 2 +-
>> java/org/apache/catalina/servlets/LocalStrings_fr.properties | 2 ++
>> java/org/apache/catalina/util/LocalStrings_ja.properties | 2 --
>> java/org/apache/coyote/http2/LocalStrings_fr.properties | 2 ++
>> java/org/apache/tomcat/util/modeler/LocalStrings_fr.properties | 1 +
>> java/org/apache/tomcat/util/net/LocalStrings_fr.properties | 2 ++
>> webapps/docs/changelog.xml | 4 ++++
>> 7 files changed, 12 insertions(+), 3 deletions(-)
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Missing git commit emails
Posted by Rainer Jung <ra...@kippdata.de>.
What could we do to avoid those summary emails, more precisely to
reliably get the detail emails? Currently a review via email often is
not possible due to the missing detail emails.
I wonder whether the occurence of these "no details, instead just a
summary" emails has anything to do with the exact work flow of pulling
branching and pushing on the local repos side. Or whether it has
anything to do with us using two different git repos (at Github and
gitbox at Apache).
Sometimes it happens direct after a change of committer, sometimes the
commits in such a block go back in time. But the one case in master
cited below has no such obvious peculiarity. All of the commits and also
the ones directly before and after that block come from Mark, so no
change, the time increases monotonically:
commit e0c112c514b07e5c323ca3a184fe26029e3cde4e
Author: Mark Thomas <ma...@apache.org>
Date: Fri Apr 26 21:56:07 2019 +0100
Import update Czech translations from POEDitor
BEGIN BUNDLED COMMITS
commit a01cff1cc3fe5c86559c071e7941699b45ef94d5
Author: Mark Thomas <ma...@apache.org>
Date: Fri Apr 26 21:52:04 2019 +0100
Import updated French translations
commit 16ea77018aaa7bd7b0ecd69cf6bf3771be59c2c6
Author: Mark Thomas <ma...@apache.org>
Date: Fri Apr 26 21:51:32 2019 +0100
Import updated Japanese translations from POEditor
END BUNDLED COMMITS
commit c3e33a090791bf3abdeead4075d403f6ab337e97
Author: Mark Thomas <ma...@apache.org>
Date: Fri Apr 26 20:56:27 2019 +0100
Remove unused translations
commit 88e03792f840bdbc2bbf07d38074823e17bff412
Author: Mark Thomas <ma...@apache.org>
Date: Fri Apr 26 20:55:18 2019 +0100
Import updated French translations from POEditor
I am sorry not to have any precise ideas currently, but I am willing to
help eg. by exercising a couple of different work flows, using different
repositories etc. But at the moment I don't have any good ideas about
where to start.
Thanks and regards,
Rainer
Am 26.04.2019 um 23:00 schrieb markt@apache.org:> This is an automated
email from the ASF dual-hosted git repository.
>
> markt pushed a change to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git.
>
>
> from c3e33a0 Remove unused translations
> new 16ea770 Import updated Japanese translations from POEditor
> new a01cff1 Import updated French translations
>
> The 20788 revisions listed above as "new" are entirely new to this
> repository and will be described in separate emails. The revisions
> listed as "add" were already present in the repository and have only
> been added to this reference.
>
>
> Summary of changes:
> java/org/apache/catalina/loader/LocalStrings_ja.properties | 2 +-
> java/org/apache/catalina/servlets/LocalStrings_fr.properties | 2 ++
> java/org/apache/catalina/util/LocalStrings_ja.properties | 2 --
> java/org/apache/coyote/http2/LocalStrings_fr.properties | 2 ++
> java/org/apache/tomcat/util/modeler/LocalStrings_fr.properties | 1 +
> java/org/apache/tomcat/util/net/LocalStrings_fr.properties | 2 ++
> webapps/docs/changelog.xml | 4 ++++
> 7 files changed, 12 insertions(+), 3 deletions(-)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org