You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/29 23:01:04 UTC
[GitHub] [incubator-superset] riahk opened a new pull request #11109: feat: saved query list actions
riahk opened a new pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109
### SUMMARY
- [x] Add query edit, query link copy, query delete action functionality
- [x] Add bulk select/delete functionality
- [x] Create `ActionsBar` component
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1283" alt="Screen Shot 2020-09-29 at 3 59 06 PM" src="https://user-images.githubusercontent.com/8216382/94625102-d056b900-026c-11eb-92be-f1106ce8f647.png">
<img width="1289" alt="Screen Shot 2020-09-29 at 3 59 12 PM" src="https://user-images.githubusercontent.com/8216382/94625105-d2207c80-026c-11eb-8daf-4352b909e915.png">
<img width="1292" alt="Screen Shot 2020-09-29 at 3 59 28 PM" src="https://user-images.githubusercontent.com/8216382/94625107-d482d680-026c-11eb-93eb-4d8b237a7330.png">
### TEST PLAN
- [ ] Update `SavedQueryList_spec.js`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] riahk commented on a change in pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
riahk commented on a change in pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#discussion_r497866821
##########
File path: superset-frontend/src/components/ListView/ActionsBar.tsx
##########
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled } from '@superset-ui/core';
+import TooltipWrapper from 'src/components/TooltipWrapper';
+import Icon from 'src/components/Icon';
+
+/* type ActionProps = {
+ label: string;
+ tooltip?: string | React.ReactElement;
+ placement?: string;
+ icon: IconName | string;
+ onClick: () => void;
+}; */
+
+type ActionsBarProps = {
+ actions: Array<any>;
Review comment:
I was having some issues with typescript when I tried that, mainly with the specific `IconName` type we use. I'll try again, might have missed something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#issuecomment-701599419
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=h1) Report
> Merging [#11109](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/03eebd3019c4942f9a8835038cc6a932a0a85033?el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `57.60%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11109 +/- ##
==========================================
- Coverage 62.25% 62.19% -0.07%
==========================================
Files 433 434 +1
Lines 14446 14528 +82
Branches 3655 3669 +14
==========================================
+ Hits 8993 9035 +42
- Misses 5273 5312 +39
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.19% <57.60%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.72% <33.33%> (-0.96%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `64.10% <52.63%> (-22.94%)` | :arrow_down: |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | `92.30% <92.30%> (ø)` | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `72.26% <0.00%> (+0.47%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=footer). Last update [03eebd3...6df0eb6](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#discussion_r497844477
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -173,11 +284,52 @@ function SavedQueryList({
{
Cell: ({ row: { original } }: any) => {
const handlePreview = () => {}; // openQueryPreviewModal(original); // TODO: open preview modal
- const handleEdit = () => {}; // handleQueryEdit(original); // TODO: navigate to sql editor with selected query open
- const handleCopy = () => {}; // TODO: copy link to clipboard
- const handleDelete = () => {}; // openQueryDeleteModal(original);
+ const handleEdit = () => {
+ openInSqlLab(original.id);
+ };
+ const handleCopy = () => {
+ copyQueryLink(original.id);
+ };
+ const handleDelete = () => setQueryCurrentlyDeleting(original); // openQueryDeleteModal(original);
- return (
+ const actions = [
+ {
+ label: 'preview-action',
+ tooltip: t('Query preview'),
+ placement: 'bottom',
+ icon: 'binoculars',
+ onClick: handlePreview,
+ },
+ canEdit
+ ? {
+ label: 'edit-action',
+ tooltip: t('Edit query'),
+ placement: 'bottom',
+ icon: 'edit',
+ onClick: handleEdit,
+ }
+ : null,
+ {
+ label: 'copy-action',
+ tooltip: t('Copy query URL'),
+ placement: 'bottom',
+ icon: 'copy',
+ onClick: handleCopy,
+ },
+ canDelete
+ ? {
+ label: 'delete-action',
+ tooltip: t('Delete query'),
+ placement: 'bottom',
+ icon: 'trash',
+ onClick: handleDelete,
+ }
+ : null,
+ ].filter(item => !!item);
+
+ return <ActionsBar actions={actions} />;
+
+ /* return (
Review comment:
is there any reason to keep this commented out code around?
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -299,17 +450,92 @@ function SavedQueryList({
return (
<>
<SubMenu {...menuData} />
- <ListView<SavedQueryObject>
- className="saved_query-list-view"
- columns={columns}
- count={queryCount}
- data={queries}
- fetchData={fetchData}
- filters={filters}
- initialSort={initialSort}
- loading={loading}
- pageSize={PAGE_SIZE}
- />
+ {queryCurrentlyDeleting && (
+ <DeleteModal
+ description={t(
+ 'This action will permanently delete the saved query.',
+ )}
+ onConfirm={() => {
+ if (queryCurrentlyDeleting) {
+ handleQueryDelete(queryCurrentlyDeleting);
+ }
+ }}
+ onHide={() => setQueryCurrentlyDeleting(null)}
+ open
+ title={t('Delete Query?')}
+ />
+ )}
+ <ConfirmStatusChange
+ title={t('Please confirm')}
+ description={t('Are you sure you want to delete the selected queries?')}
+ onConfirm={handleBulkQueryDelete}
+ >
+ {confirmDelete => {
+ const bulkActions: ListViewProps['bulkActions'] = canDelete
+ ? [
+ {
+ key: 'delete',
+ name: t('Delete'),
+ onSelect: confirmDelete,
+ type: 'danger',
+ },
+ ]
+ : [];
+
+ return (
+ <ListView<SavedQueryObject>
+ className="saved_query-list-view"
+ columns={columns}
+ count={queryCount}
+ data={queries}
+ fetchData={fetchData}
+ filters={filters}
+ initialSort={initialSort}
+ loading={loading}
+ pageSize={PAGE_SIZE}
+ bulkActions={bulkActions}
+ bulkSelectEnabled={bulkSelectEnabled}
+ disableBulkSelect={toggleBulkSelect}
+ renderBulkSelectCopy={selected => {
Review comment:
I don't think we need this prop, saved queries do not have physical/virtual distinction.
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -61,25 +66,126 @@ function SavedQueryList({
addSuccessToast,
}: SavedQueryListProps) {
const {
- state: { loading, resourceCount: queryCount, resourceCollection: queries },
+ state: {
+ loading,
+ resourceCount: queryCount,
+ resourceCollection: queries,
+ bulkSelectEnabled,
+ },
hasPerm,
fetchData,
- // refreshData, //TODO: add back later when editing?
+ toggleBulkSelect,
+ refreshData,
} = useListViewResource<SavedQueryObject>(
'saved_query',
t('saved_queries'),
addDangerToast,
);
+ const [
+ queryCurrentlyDeleting,
+ setQueryCurrentlyDeleting,
+ ] = useState<SavedQueryObject | null>(null);
+
const canCreate = hasPerm('can_add');
const canEdit = hasPerm('can_edit');
const canDelete = hasPerm('can_delete');
+ const openNewQuery = function () {
+ window.open(`${window.location.origin}/superset/sqllab?new=true`);
+ };
+
const menuData: SubMenuProps = {
activeChild: 'Saved Queries',
...commonMenuData,
};
+ menuData.primaryButton = {
+ name: t('+ Query'),
+ onClick: openNewQuery,
+ };
+
+ if (canDelete) {
+ menuData.secondaryButton = {
+ name: t('Bulk Select'),
+ onClick: toggleBulkSelect,
+ };
+ }
+
+ // Action methods
+ const openInSqlLab = function (id: number) {
+ window.open(`${window.location.origin}/superset/sqllab?savedQueryId=${id}`);
Review comment:
same here re: arrow function
##########
File path: superset-frontend/spec/javascripts/views/CRUD/data/savedquery/SavedQueryList_spec.jsx
##########
@@ -108,6 +117,51 @@ describe('SavedQueryList', () => {
);
});
+ it('renders ActionsBar in table', () => {
Review comment:
Thanks for adding tests!
##########
File path: superset-frontend/src/components/ListView/ActionsBar.tsx
##########
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled } from '@superset-ui/core';
+import TooltipWrapper from 'src/components/TooltipWrapper';
+import Icon from 'src/components/Icon';
+
+/* type ActionProps = {
+ label: string;
+ tooltip?: string | React.ReactElement;
+ placement?: string;
+ icon: IconName | string;
+ onClick: () => void;
+}; */
+
+type ActionsBarProps = {
+ actions: Array<any>;
Review comment:
can we add an action type here? Looks like there's already one commented out above
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -61,25 +66,126 @@ function SavedQueryList({
addSuccessToast,
}: SavedQueryListProps) {
const {
- state: { loading, resourceCount: queryCount, resourceCollection: queries },
+ state: {
+ loading,
+ resourceCount: queryCount,
+ resourceCollection: queries,
+ bulkSelectEnabled,
+ },
hasPerm,
fetchData,
- // refreshData, //TODO: add back later when editing?
+ toggleBulkSelect,
+ refreshData,
} = useListViewResource<SavedQueryObject>(
'saved_query',
t('saved_queries'),
addDangerToast,
);
+ const [
+ queryCurrentlyDeleting,
+ setQueryCurrentlyDeleting,
+ ] = useState<SavedQueryObject | null>(null);
+
const canCreate = hasPerm('can_add');
const canEdit = hasPerm('can_edit');
const canDelete = hasPerm('can_delete');
+ const openNewQuery = function () {
+ window.open(`${window.location.origin}/superset/sqllab?new=true`);
Review comment:
Any reason not to use an arrow function here?
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -61,25 +66,126 @@ function SavedQueryList({
addSuccessToast,
}: SavedQueryListProps) {
const {
- state: { loading, resourceCount: queryCount, resourceCollection: queries },
+ state: {
+ loading,
+ resourceCount: queryCount,
+ resourceCollection: queries,
+ bulkSelectEnabled,
+ },
hasPerm,
fetchData,
- // refreshData, //TODO: add back later when editing?
+ toggleBulkSelect,
+ refreshData,
} = useListViewResource<SavedQueryObject>(
'saved_query',
t('saved_queries'),
addDangerToast,
);
+ const [
+ queryCurrentlyDeleting,
+ setQueryCurrentlyDeleting,
+ ] = useState<SavedQueryObject | null>(null);
+
const canCreate = hasPerm('can_add');
const canEdit = hasPerm('can_edit');
const canDelete = hasPerm('can_delete');
+ const openNewQuery = function () {
+ window.open(`${window.location.origin}/superset/sqllab?new=true`);
+ };
+
const menuData: SubMenuProps = {
activeChild: 'Saved Queries',
...commonMenuData,
};
+ menuData.primaryButton = {
+ name: t('+ Query'),
+ onClick: openNewQuery,
+ };
+
+ if (canDelete) {
+ menuData.secondaryButton = {
+ name: t('Bulk Select'),
+ onClick: toggleBulkSelect,
+ };
+ }
+
+ // Action methods
+ const openInSqlLab = function (id: number) {
+ window.open(`${window.location.origin}/superset/sqllab?savedQueryId=${id}`);
+ };
+
+ const copyQueryLink = function (id: number) {
+ const selection: Selection | null = document.getSelection();
Review comment:
same here re: arrow function
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -109,6 +109,8 @@ class TabbedSqlEditors extends React.PureComponent {
...URI(window.location).search(true),
};
+ console.log('query', query);
Review comment:
do we still want to keep this log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#issuecomment-701599419
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=h1) Report
> Merging [#11109](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/03eebd3019c4942f9a8835038cc6a932a0a85033?el=desc) will **decrease** coverage by `1.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11109 +/- ##
==========================================
- Coverage 62.25% 61.14% -1.11%
==========================================
Files 433 385 -48
Lines 14446 24334 +9888
Branches 3655 0 -3655
==========================================
+ Hits 8993 14880 +5887
- Misses 5273 9454 +4181
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.14% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | | |
| [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | | |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | | |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | | |
| [...dashboard/components/gridComponents/new/NewRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdSb3cuanN4) | | |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | | |
| [...d/src/dashboard/util/getLeafComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExlYWZDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| ... and [808 more](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=footer). Last update [03eebd3...5b2e9e9](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] riahk closed pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
riahk closed pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#discussion_r497847844
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -299,17 +450,92 @@ function SavedQueryList({
return (
<>
<SubMenu {...menuData} />
- <ListView<SavedQueryObject>
- className="saved_query-list-view"
- columns={columns}
- count={queryCount}
- data={queries}
- fetchData={fetchData}
- filters={filters}
- initialSort={initialSort}
- loading={loading}
- pageSize={PAGE_SIZE}
- />
+ {queryCurrentlyDeleting && (
+ <DeleteModal
+ description={t(
+ 'This action will permanently delete the saved query.',
+ )}
+ onConfirm={() => {
+ if (queryCurrentlyDeleting) {
+ handleQueryDelete(queryCurrentlyDeleting);
+ }
+ }}
+ onHide={() => setQueryCurrentlyDeleting(null)}
+ open
+ title={t('Delete Query?')}
+ />
+ )}
+ <ConfirmStatusChange
+ title={t('Please confirm')}
+ description={t('Are you sure you want to delete the selected queries?')}
+ onConfirm={handleBulkQueryDelete}
+ >
+ {confirmDelete => {
+ const bulkActions: ListViewProps['bulkActions'] = canDelete
+ ? [
+ {
+ key: 'delete',
+ name: t('Delete'),
+ onSelect: confirmDelete,
+ type: 'danger',
+ },
+ ]
+ : [];
+
+ return (
+ <ListView<SavedQueryObject>
+ className="saved_query-list-view"
+ columns={columns}
+ count={queryCount}
+ data={queries}
+ fetchData={fetchData}
+ filters={filters}
+ initialSort={initialSort}
+ loading={loading}
+ pageSize={PAGE_SIZE}
+ bulkActions={bulkActions}
+ bulkSelectEnabled={bulkSelectEnabled}
+ disableBulkSelect={toggleBulkSelect}
+ renderBulkSelectCopy={selected => {
Review comment:
The ListView component already generates a default copy, this prop just just for overriding it (needed for datasets)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#issuecomment-701599419
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=h1) Report
> Merging [#11109](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/03eebd3019c4942f9a8835038cc6a932a0a85033?el=desc) will **decrease** coverage by `1.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11109 +/- ##
==========================================
- Coverage 62.25% 61.17% -1.08%
==========================================
Files 433 385 -48
Lines 14446 24334 +9888
Branches 3655 0 -3655
==========================================
+ Hits 8993 14886 +5893
- Misses 5273 9448 +4175
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.17% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | | |
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | | |
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | | |
| [superset-frontend/src/dashboard/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9pbmRleC5qcw==) | | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | | |
| ... and [808 more](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=footer). Last update [03eebd3...5b2e9e9](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] riahk closed pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
riahk closed pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#issuecomment-701599419
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#issuecomment-701599419
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=h1) Report
> Merging [#11109](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/03eebd3019c4942f9a8835038cc6a932a0a85033?el=desc) will **decrease** coverage by `1.12%`.
> The diff coverage is `57.60%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11109 +/- ##
==========================================
- Coverage 62.25% 61.12% -1.13%
==========================================
Files 433 819 +386
Lines 14446 38862 +24416
Branches 3655 3669 +14
==========================================
+ Hits 8993 23754 +14761
- Misses 5273 14927 +9654
- Partials 180 181 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.19% <57.60%> (-0.07%)` | :arrow_down: |
| #python | `60.48% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.72% <33.33%> (-0.96%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `64.10% <52.63%> (-22.94%)` | :arrow_down: |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | `92.30% <92.30%> (ø)` | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/e96dbf2cfef0\_datasource\_cluster\_fk.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOTZkYmYyY2ZlZjBfZGF0YXNvdXJjZV9jbHVzdGVyX2ZrLnB5) | `0.00% <0.00%> (ø)` | |
| [...ions/versions/e553e78e90c5\_add\_druid\_auth\_py\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNTUzZTc4ZTkwYzVfYWRkX2RydWlkX2F1dGhfcHlfcHkucHk=) | `0.00% <0.00%> (ø)` | |
| [...set/migrations/versions/55179c7f25c7\_sqla\_descr.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81NTE3OWM3ZjI1Yzdfc3FsYV9kZXNjci5weQ==) | `0.00% <0.00%> (ø)` | |
| [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [383 more](https://codecov.io/gh/apache/incubator-superset/pull/11109/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=footer). Last update [03eebd3...6df0eb6](https://codecov.io/gh/apache/incubator-superset/pull/11109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#discussion_r497867766
##########
File path: superset-frontend/src/components/ListView/ActionsBar.tsx
##########
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled } from '@superset-ui/core';
+import TooltipWrapper from 'src/components/TooltipWrapper';
+import Icon from 'src/components/Icon';
+
+/* type ActionProps = {
+ label: string;
+ tooltip?: string | React.ReactElement;
+ placement?: string;
+ icon: IconName | string;
+ onClick: () => void;
+}; */
+
+type ActionsBarProps = {
+ actions: Array<any>;
Review comment:
Can you try importing the `IconProps` and referencing `IconProps["name"]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #11109: feat: saved query list actions
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #11109:
URL: https://github.com/apache/incubator-superset/pull/11109#discussion_r497843559
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -109,6 +109,8 @@ class TabbedSqlEditors extends React.PureComponent {
...URI(window.location).search(true),
};
+ console.log('query', query);
Review comment:
Nit: unnecessary console :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org