[GitHub] spark pull request #19640: [SPARK-16986][CORE][WEB-UI] Support configure his...

[dbolshak <gi...@git.apache.org>]

Github user dbolshak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19640#discussion_r149087915
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2742,6 +2742,11 @@ private[spark] object Utils extends Logging {
         }
       }
     
    +  def getTimeZone: TimeZone = {
    --- End diff --
    
    Could you please image that this method will be used outside scope of the current issue?
    What's about users who does not have spark history at all?
    
    The name of method, the class and the package does not tell us that this method somehow related ONLY to history server, such API makes me easy to do wrong assumptions.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org