You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 20:36:51 UTC
[GitHub] [superset] mapshen opened a new issue #15749: Cursor falling behind in SQL Lab
mapshen opened a new issue #15749:
URL: https://github.com/apache/superset/issues/15749
When I type a SQL query in SQL Lab, the cursor doesn't align with where I'm actually typing. This can be reproduced in Chrome, Firefox and Edge.
I suspect this is related to the following issues and MRs:
- https://github.com/apache/superset/issues/9095
- https://github.com/apache/superset/pull/9183
- https://github.com/apache/superset/issues/9253
- https://github.com/apache/superset/pull/9264
Since I can apply this [fix](https://github.com/apache/superset/pull/9183#issuecomment-624204443) manually in the browser to get it working.
### Expected results
The cursor can roughly lines up.
### Actual results
It doesn't.
#### How to reproduce the bug
1. Go to 'SQL Lab'
2. Type in your query
4. See error
### Environment
`docker pull apache/superset:1.2.0`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] thomas-ca-pro commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
thomas-ca-pro commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-947717643
I'm having the same issue. The "menlo" font produces cursor missalignment for long lines with bolded chars.
Monaco and lucida console are fine on windows 10 with edge (chrome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rubenssoto commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
rubenssoto commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-884518843
Hi Guys,
Do you know anyone who can help us?
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-889430725
@rusackas We dug deep into this issue and it seems to be caused by the font "Lucida Consol" added https://github.com/apache/superset/pull/12423 as per https://github.com/apache/superset/pull/12423#discussion_r556716051.
We tried both Menlo (default on Mac) and Lucida Consol (manually installed), they work fine. However, on Win 10, Menlo is not available by default and Lucida Consol will be picked in sequence, which throws everything off. I am not clear why this is the case (not a frontend developer by trade :)), but removing Lucida Consol worked.
Can we remove "Lucida Consol"? Or even better, have we considered prepackage all the fonts needed into the docker image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-922105342
@mapshen https://github.com/apache/superset/pull/16536 should have fixed the issue, can you double check and confirm? closing issue for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rubenssoto commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
rubenssoto commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-881838499
Hello,
is it your problem?
some users are reporting that the cursor is over the letter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-881897172
@rubenssoto Yes! Perhaps I should have included a screenshot but it is what you show in the screenshot and same as what was described in the issues I mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-883723783
We are encountering the same issue on version 1.0.1 (iirc, writing from a mobile right now).
The cursor offset can be so pronounced that it is a whole letter off to the left. This renders editing, copy pasting really tricky.
Refreshing the page (F5) temporarily remedies the situation. However, I haven't been successful with reproducibly triggering the issue again, so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nicovak edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
nicovak edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-993218174
I still have the issue with Chrome + Windows 11
## With `font-family`
## Without `font-family`
It looks like it's working fine with `font-family: 'Fira Code';` on Chrome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-888655626
@rusackas I couldn't reproduce either on my own PC. It might be due to some policies enforced on our browsers in the corporate environment. We are trying to see if we can pinpoint it. Please let us know too if you have any leads on what policy might have caused this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-928309180
@junlincc Sorry for the late reply and appreciate your help on trying to fix this issue so far.
Unfortunately, in my test just now with the latest image `apache/superset:fcab489860399d38bc3a66fd26dd62b7c3e3ffd5`, the issue still persists - could we please reopen this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PApostol commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
PApostol commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-964118005
I'm having the same issue on version 1.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-890131501
Thoughts @betodealmeida ?
In a perfect world, I'd love to use the font from the Superset Theme here (`theme.typography.families.monospace`) which would be `'Fira Code', 'Courier New', monospace`. But I'm hesitant to rock the boat on this thing! 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-887092020
@mapshen A handful of us are unable to reproduce this issue, at least in Chrome/Safari/Firefox on Mac. Is everyone seeing the issue here using a PC? Our same group doesn't currently have a PC to test, if this is the case. @mapshen do you think you could troubleshoot a bit more and open a PR? I'd be happy to test it on all the mac browsers, if you're able to fix it for the PC browser(s) having a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] thomas-ca-pro commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
thomas-ca-pro commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-964166192
I think that as long as `menlo` appears first in the list of fonts used by ace-editor, I'll have this issue on credge.
I think that the incriminated line is [here](https://github.com/apache/superset/blob/5948a9fd0246b9d67fd2074a613f081e53a19670/superset-frontend/src/SqlLab/main.less#L373)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ziggekatten commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
ziggekatten commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-963908379
This is driving me nuts....is there a way to work around this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zrait commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
zrait commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-888730323
I'm seeing this on Chrome PC using version 1.2 from PyPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #15749:
URL: https://github.com/apache/superset/issues/15749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-928309180
@junlincc Sorry for the late reply and appreciate your help on trying to fix this issue so far.
Unfortunately, in my test just now with the latest image `apache/superset:fcab489860399d38bc3a66fd26dd62b7c3e3ffd5`, the issue still persists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-928309180
@junlincc Sorry for the late reply and appreciate your help on trying to fix this issue so far.
Unfortunately, in my test just now with the latest image `apache/superset:fcab489860399d38bc3a66fd26dd62b7c3e3ffd5`, the issue still persists - could we please reopen this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Dieken commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
Dieken commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-917605523
```
perl -i.bak -pe "s/'Monaco\\\\'/'MonacoXXX\\\\'/g" ~/superset/assets/dist/vendors-major.facef8359e4e34d9cc58.chunk.js
```
This helps me, you may need clear your local browser cache first.
<img width="1228" alt="image" src="https://user-images.githubusercontent.com/2365/132983616-3934abb3-e36b-4569-8ab2-f9ded2d7b78b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-891893795
@rusackas @betodealmeida What would be the path forward? Can we remove "Lucida Consol"? This basically renders the SQL Lab useless, so your help would be greatly appreciated. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-928309180
@junlincc Sorry for the late reply and appreciate your help on trying to fix this issue so far.
Unfortunately, in my test just now with the latest image `apache/superset:fcab489860399d38bc3a66fd26dd62b7c3e3ffd5`, the issue still persists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-885720437
This is still happening when running the latest, which is based off of `9c854ff1f1ab80b26438a3b6d91ca9b44b5f2a7a`.
I think the root cause is similar to this: https://github.com/apache/superset/pull/9183#issuecomment-624204443. There are two `.ace_editor` classes applied to the editor. Disabling the `font-family` attribute in one and having the `font` attribute in another applied seem to be able to get the cursor properly aligned.
Before:
After:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-885720437
This is still happening when running the latest, which is based off of `9c854ff1f1ab80b26438a3b6d91ca9b44b5f2a7a`.
I think the root cause is similar to this: https://github.com/apache/superset/pull/9183#issuecomment-624204443. There are two `.ace_editor` classes applied to the editor. Disabling the `font-family` attribute in one and having the `font` attribute in another applied seem to be able to get the cursor properly aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-885720437
This is still happening when running the latest, which is based off of `9c854ff1f1ab80b26438a3b6d91ca9b44b5f2a7a`.
I think the root cause is similar to this: https://github.com/apache/superset/pull/9183#issuecomment-624204443. There are two `.ace_editor` classes applied to the SQL editor. Disabling the `font-family` attribute in one and having the `font` attribute in another applied seem to be able to get the cursor properly aligned.
Before:
After:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nicovak edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
nicovak edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-993218174
I still have the issue with Chrome + Windows 11
## With `font-family`
## Without `font-family`
It looks like it's working fine with `font-family: 'Fira Code';` on Chrome
## Working fine without any changes when editing a Dataset Query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
rumbin commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-887218405
PC, Win 10 in our case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mapshen edited a comment on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
mapshen edited a comment on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-885720437
This is still happening when running the latest, which is based off of `9c854ff1f1ab80b26438a3b6d91ca9b44b5f2a7a`.
I think the root cause is similar to this: https://github.com/apache/superset/pull/9183#issuecomment-624204443. There are two `.ace_editor` classes applied to the editor. Disabling the `font-family` attribute in one and having the `font` attribute in another applied seem to be able to get the cursor properly aligned.
Before:
After:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-885318028
https://github.com/apache/superset/pull/15820
please check out lasted master. lmk thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nicovak commented on issue #15749: Cursor falling behind in SQL Lab
Posted by GitBox <gi...@apache.org>.
nicovak commented on issue #15749:
URL: https://github.com/apache/superset/issues/15749#issuecomment-993218174
I still have the issue with Chrome + Windows 11
## With `font-family`
## Without `font-family`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org