You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/19 12:23:42 UTC
[GitHub] [arrow-datafusion] alamb opened a new issue #1613: Remove redundant`is_numeric` and other checks for DataType
alamb opened a new issue #1613:
URL: https://github.com/apache/arrow-datafusion/issues/1613
`arrow-rs` has some functions to check data type, and the logic is also in datafusion, for example, https://docs.rs/arrow/7.0.0/arrow/datatypes/enum.DataType.html#method.is_numeric
We should reduce the redundancy in DataFusion to make the codebase clear.
_Originally posted by @liukun4515 in https://github.com/apache/arrow-datafusion/pull/1606#discussion_r787306626_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1613: Remove redundant`is_numeric` and other checks for DataType
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1613:
URL: https://github.com/apache/arrow-datafusion/issues/1613#issuecomment-1022880345
Now we can focus on other issues, and deal with them after other stabilization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on issue #1613: Remove redundant`is_numeric` and other checks for DataType
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #1613:
URL: https://github.com/apache/arrow-datafusion/issues/1613#issuecomment-1022831491
`is_numeric` in `arrow-rs` seems not to be same as in `arrow-datafusion` because `DataType::Decimal` is not included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1613: Remove redundant`is_numeric` and other checks for DataType
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1613:
URL: https://github.com/apache/arrow-datafusion/issues/1613#issuecomment-1022879204
> `is_numeric` in `arrow-rs` seems not to be same as in `arrow-datafusion` because `DataType::Decimal` is not included.
@HaoYang670
In the PG or Spark, the decimal is included in the `numeric`.
Because the decimal is in development, some codes may be not consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #1613: Remove redundant`is_numeric` and other checks for DataType
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1613:
URL: https://github.com/apache/arrow-datafusion/issues/1613#issuecomment-1018746245
This is a good one -- just delete some code from DataFusion 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org