You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Lei (Eddy) Xu (JIRA)" <ji...@apache.org> on 2017/03/23 18:23:41 UTC

[jira] [Created] (SENTRY-1676) FullUpdateInitializer#createInitialUpdate should not throw RuntimeException

Lei (Eddy) Xu created SENTRY-1676:
-------------------------------------

             Summary: FullUpdateInitializer#createInitialUpdate should not throw RuntimeException
                 Key: SENTRY-1676
                 URL: https://issues.apache.org/jira/browse/SENTRY-1676
             Project: Sentry
          Issue Type: Sub-task
    Affects Versions: sentry-ha-redesign
            Reporter: Lei (Eddy) Xu


In {{FullUpdateInitialize#createInitialUpdate}}, it wraps any exception occurred in db tasks using {{RuntimeException}}

{code:title=FullUpdateInitialize.createInitialUpdate()}
 // Fail the HMS startup if tasks are not all successful and
 // fail on partial updates flag is set in the config.
 if (!callResult.getSuccessStatus() && failOnRetry) {
    throw new RuntimeException(callResult.getFailure());
 }
{code}

We should not use {{RumtimeException}} here, because it is an unchecked exception, which is easier to miss to catch from the callers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)